Repository navigation
Py_DEBUG vs PYTHON_WITH_PYDEBUG build directives #362
Description
Is there a differences between Py_DEBUG and PYTHON_WITH_DEBUG
Py_DEBUG is the official flags name that Python uses to build Python with debug. But we never define Py_DEBUG at all, only PYTHON_WITH_DEBUG on the setup.py script. Is there a difference I'm overseeing or do they just need renaming?
Activity
vmuriart commented on Feb 7, 2017
Just browsed the history and found when they were introduced into runtime.cs atleast (Py_DEBUG is present in other files) Christian introduced Py_DEBUG back in 2004 (035b7ad). @tonyroberts introduced PYTHON_WITH_PYDEBUG on 2014 (5062377) for Python3/Mono compatibility.
Looks like we just need to rename the remaining Py_DEBUG to PYTHON_WITH_PYDEBUG to close this issue. And/Or add an option to define Py_DEBUG on setup.py for Python 2.7 (since it doesnt have abiflags)
Does that sound about right @tonyroberts ?
Combine Py_DEBUG and PYTHON_WITH_PYDEBUG flags
Rebase with master (#2)