FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Find MSBuild from Visual Studio 2017 · Issue #434 · pythonnet/pythonnet · GitHub

  1. pythonnet
  2. pythonnet

Repository navigation

Find MSBuild from Visual Studio 2017 #434

Closed
Closed
Find MSBuild from Visual Studio 2017#434

Description

christopherpow
opened on Mar 22, 2017

pip install pythonnet fails to find msbuild from Visual Studio 2017 because it is MSBuild 15.0 not MSBuild 14.0.

Activity

  1. den-run-ai commented on Mar 22, 2017

    den-run-ai
    on Mar 22, 2017
    Contributor

    @christopherpow pull requests are welcome! I don't have VS 2017 installed, because PTVS 2017 is still in preview.

    Also please include the full log or traceback that you get from the build.

  2. den-run-ai commented on Mar 22, 2017

    den-run-ai
    on Mar 22, 2017
    Contributor

    @christopherpow the change is necessary only in 2 places:

    pythonnet/setup.py

    Line 67 in 51ec8a4

    VS_KEYS = (

    https://github.com/pythonnet/pythonnet/blob/0a478024175e52106d9d4ff2230e1f505e56d7d8/conda.recipe/bld.bat

  3. christopherpow commented on Mar 22, 2017

    christopherpow
    on Mar 22, 2017
    ContributorAuthor

    I noticed. Trying to get my pull request to cooperate.

  4. filmor commented on Mar 23, 2017

    filmor
    on Mar 23, 2017
    Member

    Fixed via #435.

  5. filmor
    closed this as completedon Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL