fix(cmd): checking process.DEVNUL were needlessly opening `os.devnull` · pythonthings/GitPython@12db6bb · GitHub

1. pythonthings
2. GitPython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 12db6bb

Browse filesBrowse the repository at this point in the historyBrowse files

ankostis

authored

fix(cmd): checking process.DEVNUL were needlessly opening os.devnull

Fixes resource-leak warning on Windows Puython-3.5.3+: D:\python-3.5.2.amd64\lib\site-packages\git\cmd.py:583: ResourceWarning: unclosed file <_io.BufferedWriter name='nul'> else getattr(subprocess, 'DEVNULL', open(os.devnull, 'wb')))

1 parent b197de0 commit 12db6bb
Copy full SHA for 12db6bb

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • cmd.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -580,7 +580,7 @@ def execute(self, command,
580	580
581	581	stdout_sink = (PIPE
582	582	if with_stdout
583		- else getattr(subprocess, 'DEVNULL', open(os.devnull, 'wb')))
	583	+ else getattr(subprocess, 'DEVNULL', None) or open(os.devnull, 'wb'))
584	584	log.debug("Popen(%s, cwd=%s, universal_newlines=%s, shell=%s)",
585	585	command, cwd, universal_newlines, shell)
586	586	try:

0 commit comments

Comments

0 (0)