Commit daa3f35
Fix Git.transform_kwarg
Kwargs were not transformed correctly if a value was set to 0 due to
wrong if condition.
Signed-off-by: František Nečas <fifinecas@seznam.cz>1 parent 8020433 commit daa3f35
2 files changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -893,7 +893,7 @@ def transform_kwarg(self, name, value, split_single_char_options): | |||
| 893 | 893 | else: | |
| 894 | 894 | if value is True: | |
| 895 | 895 | return ["--%s" % dashify(name)] | |
| 896 | - elif value not in (False, None): | ||
| 896 | + elif value is not False and value is not None: | ||
| 897 | 897 | return ["--%s=%s" % (dashify(name), value)] | |
| 898 | 898 | return [] | |
| 899 | 899 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -86,6 +86,7 @@ def test_it_transforms_kwargs_into_git_command_arguments(self): | |||
| 86 | 86 | ||
| 87 | 87 | assert_equal(["--max-count"], self.git.transform_kwargs(**{'max_count': True})) | |
| 88 | 88 | assert_equal(["--max-count=5"], self.git.transform_kwargs(**{'max_count': 5})) | |
| 89 | + assert_equal(["--max-count=0"], self.git.transform_kwargs(**{'max_count': 0})) | ||
| 89 | 90 | assert_equal([], self.git.transform_kwargs(**{'max_count': None})) | |
| 90 | 91 | ||
| 91 | 92 | # Multiple args are supported by using lists/tuples | |
0 commit comments