Commit edf9fc5
committed
Git: guard against passing False to git commands
git does not accept commands of the form:
git cmd --xx=False
or
git cmd -xFalse
This patch prevents transform_kwargs from producing
command lines with those values.
This adds some flexibility/syntactic sugar for callers
since they can then assume that kwargs with a False value
are not passed to git commands.
Signed-off-by: David Aguilar <davvid@gmail.com>1 parent bf20839 commit edf9fc5
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -132,12 +132,12 @@ def transform_kwargs(self, **kwargs): | |||
| 132 | 132 | if len(k) == 1: | |
| 133 | 133 | if v is True: | |
| 134 | 134 | args.append("-%s" % k) | |
| 135 | - else: | ||
| 135 | + elif type(v) is not bool: | ||
| 136 | 136 | args.append("-%s%s" % (k, v)) | |
| 137 | 137 | else: | |
| 138 | 138 | if v is True: | |
| 139 | 139 | args.append("--%s" % dashify(k)) | |
| 140 | - else: | ||
| 140 | + elif type(v) is not bool: | ||
| 141 | 141 | args.append("--%s=%s" % (dashify(k), v)) | |
| 142 | 142 | return args | |
| 143 | 143 | ||
0 commit comments