Merge pull request #833 from python-gitlab/project-variable-update · pythonthings/python-gitlab@6c673c6 · GitHub

1. pythonthings
2. python-gitlab

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 6c673c6

Browse filesBrowse the repository at this point in the historyBrowse files

max-wittig

authored

Merge pull request python-gitlab#833 from python-gitlab/project-variable-update

fix(cli): fix update value for key not working

2 parents 8306ef2 + b766203 commit 6c673c6
Copy full SHA for 6c673c6

2 files changed

+27Lines changed: 27 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gitlab
  • mixins.py
• tools
  • cli_test_v4.sh

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gitlab/mixins.py‎

Copy file name to clipboardExpand all lines: gitlab/mixins.py

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -208,6 +208,8 @@ def create(self, data, **kwargs):
208	208	class UpdateMixin(object):
209	209	def _check_missing_update_attrs(self, data):
210	210	required, optional = self.get_update_attrs()
	211	+ # Remove the id field from the required list as it was previously moved to the http path.
	212	+ required = tuple(filter(lambda k: k != self._obj_cls._id_attr, required))
211	213	missing = []
212	214	for attr in required:
213	215	if attr not in data:

Collapse file

‎tools/cli_test_v4.sh‎

Copy file name to clipboard

100644100755

Expand all lines: tools/cli_test_v4.sh

+25Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -89,6 +89,31 @@ testcase "merge request validation" '
89	89	--iid "$MR_ID" >/dev/null 2>&1
90	90	'
91	91
	92	+ # Test project variables
	93	+ testcase "create project variable" '
	94	+ OUTPUT=$(GITLAB -v project-variable create --project-id $PROJECT_ID \
	95	+ --key junk --value car)
	96	+ '
	97	+
	98	+ testcase "get project variable" '
	99	+ OUTPUT=$(GITLAB -v project-variable get --project-id $PROJECT_ID \
	100	+ --key junk)
	101	+ '
	102	+
	103	+ testcase "update project variable" '
	104	+ OUTPUT=$(GITLAB -v project-variable update --project-id $PROJECT_ID \
	105	+ --key junk --value bus)
	106	+ '
	107	+
	108	+ testcase "list project variable" '
	109	+ OUTPUT=$(GITLAB -v project-variable list --project-id $PROJECT_ID)
	110	+ '
	111	+
	112	+ testcase "delete project variable" '
	113	+ OUTPUT=$(GITLAB -v project-variable delete --project-id $PROJECT_ID \
	114	+ --key junk)
	115	+ '
	116	+
92	117	testcase "branch deletion" '
93	118	GITLAB project-branch delete --project-id "$PROJECT_ID" \
94	119	--name branch1 >/dev/null 2>&1

0 commit comments

Comments

0 (0)