FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Always null check result of extractTypeInfo() · qicny/processing@2b4d427 · GitHub

Repository navigation

Commit 2b4d427

Browse files
committed
Always null check result of extractTypeInfo()
1 parent e09dec8 commit 2b4d427

1 file changed

Lines changed: 16 additions & 8 deletions

File tree

‎java/src/processing/mode/java/pdex/ASTGenerator.java‎

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2793,6 +2793,10 @@ protected static ASTNode findDeclaration(Name findMe) {
27932793

27942794
SimpleType stp = extracTypeInfo(findDeclaration((qn.getQualifier())));
27952795
// log(qn.getQualifier() + "->" + qn.getName());
2796+
if (stp == null) {
2797+
return null;
2798+
}
2799+
27962800
declaringClass = findDeclaration(stp.getName());
27972801

27982802
// log("QN decl class: " + getNodeAsString(declaringClass));
@@ -2810,16 +2814,15 @@ protected static ASTNode findDeclaration(Name findMe) {
28102814
// .toString()));
28112815

28122816
SimpleType stp = extracTypeInfo(findDeclaration((qnn.getQualifier())));
2813-
if (stp != null) {
2814-
declaringClass = findDeclaration(stp.getName());
2815-
constrains.clear();
2816-
constrains.add(ASTNode.TYPE_DECLARATION);
2817-
constrains.add(ASTNode.FIELD_DECLARATION);
2818-
return definedIn(declaringClass, qnn.getName().toString(),
2819-
constrains, null);
2820-
} else {
2817+
if (stp == null) {
28212818
return null;
28222819
}
2820+
declaringClass = findDeclaration(stp.getName());
2821+
constrains.clear();
2822+
constrains.add(ASTNode.TYPE_DECLARATION);
2823+
constrains.add(ASTNode.FIELD_DECLARATION);
2824+
return definedIn(declaringClass, qnn.getName().toString(),
2825+
constrains, null);
28232826
}
28242827
}
28252828
} else if (parent.getNodeType() == ASTNode.SIMPLE_TYPE) {
@@ -3010,6 +3013,11 @@ protected static ASTNode findDeclaration2(Name findMe, ASTNode alternateParent)
30103013
// .toString()));
30113014

30123015
SimpleType stp = extracTypeInfo(findDeclaration2((qnn.getQualifier()), alternateParent));
3016+
3017+
if (stp == null) {
3018+
return null;
3019+
}
3020+
30133021
// log(qnn.getQualifier() + "->" + qnn.getName());
30143022
declaringClass = findDeclaration2(stp.getName(), alternateParent);
30153023

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL