@@ -44,6 +44,7 @@
 
 
 
+
 // used by loadImage() functions
 import javax.imageio.ImageIO;
 import javax.swing.ImageIcon;
@@ -1489,23 +1490,34 @@ public void size(int w, int h) {
     size(w, h, sketchRenderer(), null);
   }
 
+
   /**
    * @param renderer Either P2D, P3D, or PDF
    */
   public void size(int w, int h, String renderer) {
     size(w, h, renderer, null);
   }
 
-/**
- * @nowebref
- */
+
+  /**
+   * @nowebref
+   */
   public void size(final int w, final int h, String renderer, String path) {
     if (!renderer.equals(sketchRenderer())) {
-      System.err.println("Because you're not running from the PDE, add this to your code:");
-      System.err.println("public String sketchRenderer() {");
-      System.err.println("  return \"" + renderer + "\";");
-      System.err.println("}");
-      throw new RuntimeException("The sketchRenderer() method is not implemented.");
+      if (external) {
+        // The PDE should have parsed it, but something still went wrong
+        final String msg =
+          String.format("Something bad happened when calling " +
+                        "size(%d, %d, %s, %s)", w, h, renderer, path);
+        throw new RuntimeException(msg);
+
+      } else {
+        System.err.println("Because you're not running from the PDE, add this to your code:");
+        System.err.println("public String sketchRenderer() {");
+        System.err.println("  return \"" + renderer + "\";");
+        System.err.println("}");
+        throw new RuntimeException("The sketchRenderer() method is not implemented.");
+      }
     }
     surface.setSize(w, h);
     g.setPath(path);  // finally, a path
@@ -1700,6 +1712,7 @@ protected PGraphics makeGraphics(int w, int h,
 
       pg.setParent(this);
       pg.setPrimary(primary);
+      System.out.println("path is " + path);
       if (path != null) {
         pg.setPath(path);
       }
@@ -1770,7 +1783,8 @@ protected PGraphics makeGraphics(int w, int h,
 
   /** Create default renderer, likely to be resized, but needed for surface init. */
   protected PGraphics createPrimaryGraphics() {
-    return makeGraphics(sketchWidth(), sketchHeight(), sketchRenderer(), null, true);
+    return makeGraphics(sketchWidth(), sketchHeight(),
+                        sketchRenderer(), sketchOutputPath(), true);
   }
 
 
@@ -9643,9 +9657,8 @@ private void deprecationWarning(String method) {
       surface.initFrame(this, backgroundColor, displayIndex, present, spanDisplays);
       surface.setTitle(getClass().getName());
       //frame.setTitle(getClass().getName());
-//    } else {
-//      // TODO necessary?
-//      surface.initOffscreen(this);
+    } else {
+      surface.initOffscreen(this);  // for PDF, PSurfaceNone, and friends
     }
 
     init();
 
@@ -27,8 +27,6 @@
 import java.awt.Cursor;
 import java.awt.event.KeyEvent;
 
-import processing.data.StringList;
-
 
 /**
  * Numbers shared throughout processing.core.
@@ -48,6 +46,7 @@ public interface PConstants {
 
   // renderers known to processing.core
 
+  /*
   // List of renderers used inside PdePreprocessor
   static final StringList rendererList = new StringList(new String[] {
     "JAVA2D", "JAVA2D_2X",
@@ -56,6 +55,7 @@ public interface PConstants {
     "LWJGL.P2D", "LWJGL.P3D",  // hmm
     "PDF"  // no DXF because that's only for beginRaw()
   });
+  */
 
   static final String JAVA2D    = "processing.core.PGraphicsJava2D";
   static final String JAVA2D_2X = "processing.core.PGraphicsJava2D2X";
 
@@ -46,7 +46,7 @@ public PSurfaceNone() { }
 
   @Override
   public void initOffscreen(PApplet sketch) {
-    // TODO Auto-generated method stub
+    this.sketch = sketch;
   }
 
 
@@ -57,8 +57,9 @@ public void initOffscreen(PApplet sketch) {
 
   @Override
   public void initFrame(PApplet sketch, int backgroundColor,
-                         int deviceIndex, boolean fullScreen,
-                         boolean spanDisplays) {
+                        int deviceIndex, boolean fullScreen,
+                        boolean spanDisplays) {
+    this.sketch = sketch;
   }
 
 
 
@@ -38,13 +38,17 @@ _ implement frameRate()
 _ implement external messages (moving the window)
 
 opengl
+X deal with some performance issues
+X   https://github.com/processing/processing/issues/3210
+X Can't run sketches with offscreen PGraphics
+X   https://github.com/processing/processing/issues/3259
+_ Merge glw code into the OpenGL library
+_   https://github.com/processing/processing/issues/3284
 _ why is createShape() implemented 4x (for P2D, P3D, and 2x versions)? 
 _   shouldn't be static, run it from the renderer, that's point of createXxx()
 _ when did setPath() sneak into PShape? API is nothing like anything else
 _ public createShape() method that takes another shape as param?
 _   should just be the constructor doing this, or copy()
-_ drawing 100k lines is slow (example from Reas)
-_   figure out what the bottleneck is here
 
 
 high priority
 
@@ -118,12 +118,14 @@ public void beginDraw() {
 
     if (document == null) {
       document = new Document(new Rectangle(width, height));
+      boolean missingPath = false;
       try {
         if (file != null) {
           //BufferedOutputStream output = new BufferedOutputStream(stream, 16384);
           output = new BufferedOutputStream(new FileOutputStream(file), 16384);
 
         } else if (output == null) {
+          missingPath = true;
           throw new RuntimeException("PGraphicsPDF requires a path " +
                                      "for the location of the output file.");
         }
@@ -132,25 +134,26 @@ public void beginDraw() {
         content = writer.getDirectContent();
 //        template = content.createTemplate(width, height);
 
-      } catch (Exception e) {
-        e.printStackTrace();
-        throw new RuntimeException("Problem saving the PDF file.");
+      } catch (RuntimeException re) {
+        if (missingPath) {
+          throw re;  // don't re-package our own error
+        } else {
+          throw new RuntimeException("Problem saving the PDF file.", re);
+        }
+
+      } catch (FileNotFoundException fnfe) {
+        throw new RuntimeException("Can't save the PDF file to " + path, fnfe);
+
+      } catch (DocumentException de) {
+        throw new RuntimeException("Error inside the PDF library.", de);
       }
 
-//      System.out.println("beginDraw fonts " + (System.currentTimeMillis() - t));
-//      g2 = content.createGraphics(width, height, getMapper());
-//      if (textMode == SHAPE) {
       g2 = content.createGraphicsShapes(width, height);
-//      } else if (textMode == MODEL) {
-//        g2 = content.createGraphics(width, height, getMapper());
-//      }
-//      g2 = createGraphics();
-//      g2 = template.createGraphics(width, height, mapper);
     }
-//    System.out.println("beginDraw " + (System.currentTimeMillis() - t0));
 
     // super in Java2D now creates an image buffer, don't do that
-//    super.beginDraw();
+    //super.beginDraw();
+
     checkSettings();
     resetMatrix(); // reset model matrix
     vertexCount = 0;
Original file line number	Diff line number	Diff line change
@@ -46,7 +46,7 @@ public PSurfaceNone() { }
46	46
47	47	@Override
48	48	public void initOffscreen(PApplet sketch) {
49		- // TODO Auto-generated method stub
	49	+ this.sketch = sketch;
50	50	}
51	51
52	52
@@ -57,8 +57,9 @@ public void initOffscreen(PApplet sketch) {
57	57
58	58	@Override
59	59	public void initFrame(PApplet sketch, int backgroundColor,
60		- int deviceIndex, boolean fullScreen,
61		- boolean spanDisplays) {
	60	+ int deviceIndex, boolean fullScreen,
	61	+ boolean spanDisplays) {
	62	+ this.sketch = sketch;
62	63	}
63	64
64	65