Commit 174a82b
committed
pythongh-140009: Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray
1 parent 4644fed commit 174a82b
2 files changed
Lines changed: 5 additions & 2 deletions
File tree
- Misc/NEWS.d/next/Core_and_Builtins
- Objects
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1 @@ | |||
| 1 | + Improve performance of dict object by replacing PyTuple_Pack with PyTuple_FromArray for small tuples. | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5083,7 +5083,8 @@ dictiter_new(PyDictObject *dict, PyTypeObject *itertype) | |||
| 5083 | 5083 | } | |
| 5084 | 5084 | if (itertype == &PyDictIterItem_Type || | |
| 5085 | 5085 | itertype == &PyDictRevIterItem_Type) { | |
| 5086 | - di->di_result = PyTuple_Pack(2, Py_None, Py_None); | ||
| 5086 | + PyObject *items[] = {Py_None, Py_None}; | ||
| 5087 | + di->di_result = PyTuple_FromArray(items, 2); | ||
| 5087 | 5088 | if (di->di_result == NULL) { | |
| 5088 | 5089 | Py_DECREF(di); | |
| 5089 | 5090 | return NULL; | |
@@ -6284,7 +6285,8 @@ dictitems_xor_lock_held(PyObject *d1, PyObject *d2) | |||
| 6284 | 6285 | } | |
| 6285 | 6286 | } | |
| 6286 | 6287 | else { | |
| 6287 | - PyObject *pair = PyTuple_Pack(2, key, val2); | ||
| 6288 | + PyObject *items[] = {key, val2}; | ||
| 6289 | + PyObject *pair = PyTuple_FromArray(items, 2); | ||
| 6288 | 6290 | if (pair == NULL) { | |
| 6289 | 6291 | goto error; | |
| 6290 | 6292 | } | |
0 commit comments