FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Container entrypoint.sh · Issue #650 · redis-stack/redis-stack · GitHub

Container entrypoint.sh #650

Description

Hi there,

There are some issues with entrypoint.sh file. Due to the way it is made, the Redis server is started as a child of process 1. When a SIGTERM comes, the PID 1 closed but do not pass the SIGTERM to children PIDs. I think this is what the author wanted to do with the usage of dumb-init.

So, there are two ways to fix this.

  1. complicated: use traps and pass SIGTERM to children processes
  2. simple: change the following:
  • #! /usr/bin/dumb-init /bin/sh to #!/bin/sh
  • ${CMD} \' to exec ${CMD} `

If two is implemented, we can see the exit message "Redis is now ready to exit, bye bye..."

Best of luck

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL