feat: simplify types treating key and payload always as optional (#380) · reflagcom/javascript@2fa4704 · GitHub

reflagcom / javascript Public

• Notifications You must be signed in to change notification settings
• Fork 13
• Star 25

• Code
• Issues 1
• Pull requests 11
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 2fa4704

Browse filesBrowse the repository at this point in the historyBrowse files

Swiftwork

authored

feat: simplify types treating key and payload always as optional (#380)

Utilizing [TypeScript intersection](microsoft/TypeScript#31838) to simplify config types. Config keys and payload can now always be `undefined`.

1 parent 025dc33 commit 2fa4704
Copy full SHA for 2fa4704

4 files changed

+12-12Lines changed: 12 additions & 12 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages
  • node-sdk
    • package.json
    • src
      • types.ts
  • react-sdk
    • package.json
    • src
      • index.tsx

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/node-sdk/package.json‎

Copy file name to clipboardExpand all lines: packages/node-sdk/package.json

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,6 @@
1	1	{
2	2	"name": "@bucketco/node-sdk",
3		- "version": "1.6.3",
	3	+ "version": "1.6.4",
4	4	"license": "MIT",
5	5	"repository": {
6	6	"type": "git",

Collapse file

‎packages/node-sdk/src/types.ts‎

Copy file name to clipboardExpand all lines: packages/node-sdk/src/types.ts

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -148,7 +148,7 @@ export type FeatureRemoteConfig =
148	148	* Describes a feature
149	149	*/
150	150	export interface Feature<
151		- TConfig extends FeatureType["config"] | undefined = EmptyFeatureRemoteConfig,
	151	+ TConfig extends FeatureType["config"] = EmptyFeatureRemoteConfig,
152	152	> {
153	153	/**
154	154	* The key of the feature.
@@ -163,11 +163,11 @@ export interface Feature<
163	163	/*
164	164	* Optional user-defined configuration.
165	165	*/
166		- config: TConfig extends undefined
167		- ? EmptyFeatureRemoteConfig
168		- : TConfig & {
	166	+ config:
	167	+ | ({
169	168	key: string;
170		- };
	169	+ } & TConfig)
	170	+ | EmptyFeatureRemoteConfig;
171	171
172	172	/**
173	173	* Track feature usage in Bucket.

Collapse file

‎packages/react-sdk/package.json‎

Copy file name to clipboardExpand all lines: packages/react-sdk/package.json

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,6 @@
1	1	{
2	2	"name": "@bucketco/react-sdk",
3		- "version": "3.1.3",
	3	+ "version": "3.1.4",
4	4	"license": "MIT",
5	5	"repository": {
6	6	"type": "git",

Collapse file

‎packages/react-sdk/src/index.tsx‎

Copy file name to clipboardExpand all lines: packages/react-sdk/src/index.tsx

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -62,7 +62,7 @@ export type FeatureRemoteConfig =
62	62	* Describes a feature
63	63	*/
64	64	export interface Feature<
65		- TConfig extends FeatureType["config"] | undefined = EmptyFeatureRemoteConfig,
	65	+ TConfig extends FeatureType["config"] = EmptyFeatureRemoteConfig,
66	66	> {
67	67	/**
68	68	* The key of the feature.
@@ -82,11 +82,11 @@ export interface Feature<
82	82	/*
83	83	* Optional user-defined configuration.
84	84	*/
85		- config: TConfig extends undefined
86		- ? EmptyFeatureRemoteConfig
87		- : TConfig & {
	85	+ config:
	86	+ | ({
88	87	key: string;
89		- };
	88	+ } & TConfig)
	89	+ | EmptyFeatureRemoteConfig;
90	90
91	91	/**
92	92	* Track feature usage in Bucket.

0 commit comments

Comments

0 (0)