fix: live reload deploys app when warnings are present #4807 (#5043) · reslear/ionic-cli@ef5706e · GitHub

1. reslear
2. ionic-cli

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit ef5706e

Browse filesBrowse the repository at this point in the historyBrowse files

triforcely

and

Michal Wilski

authored

fix: live reload deploys app when warnings are present ionic-team#4807 (ionic-team#5043)

Co-authored-by: Michal Wilski <michal.wilski.ext@eloomi.com>

1 parent 05d64e9 commit ef5706e
Copy full SHA for ef5706e

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/@ionic/cli/src/lib/project
  • react
    • serve.ts
  • vue
    • serve.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/@ionic/cli/src/lib/project/react/serve.ts‎

Copy file name to clipboardExpand all lines: packages/@ionic/cli/src/lib/project/react/serve.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -112,7 +112,7 @@ export class ReactServeCLI extends ServeCLI<ReactServeOptions> {
112	112
113	113	const strippedLine = stripAnsi(line);
114	114
115		- const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
	115	+ const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
116	116	if (compileMsgs.some(msg => strippedLine.includes(msg))) {
117	117	this.emit('ready');
118	118	return false;

Collapse file

‎packages/@ionic/cli/src/lib/project/vue/serve.ts‎

Copy file name to clipboardExpand all lines: packages/@ionic/cli/src/lib/project/vue/serve.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -63,7 +63,7 @@ export class VueServeCLI extends ServeCLI<VueServeOptions> {
63	63	}
64	64
65	65	const strippedLine = stripAnsi(line);
66		- const compileMsgs = ['Compiled successfully', 'Compiled with warnings', 'Failed to compile'];
	66	+ const compileMsgs = ['Compiled successfully', 'Compiled with', 'Failed to compile'];
67	67	if (compileMsgs.some(msg => strippedLine.includes(msg))) {
68	68	this.emit('ready');
69	69	return false;

0 commit comments

Comments

0 (0)