Merge pull request #582 from gitpython-developers/no_devnull_open · rowhit/GitPython@2ede752 · GitHub

1. rowhit
2. GitPython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 2ede752

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

authored

Merge pull request gitpython-developers#582 from gitpython-developers/no_devnull_open

fix(cmd): checking process.DEVNUL were needlessly opening `os.devnull`

2 parents 0181a40 + 12db6bb commit 2ede752
Copy full SHA for 2ede752

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • cmd.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -581,7 +581,7 @@ def execute(self, command,
581	581
582	582	stdout_sink = (PIPE
583	583	if with_stdout
584		- else getattr(subprocess, 'DEVNULL', open(os.devnull, 'wb')))
	584	+ else getattr(subprocess, 'DEVNULL', None) or open(os.devnull, 'wb'))
585	585	log.debug("Popen(%s, cwd=%s, universal_newlines=%s, shell=%s)",
586	586	command, cwd, universal_newlines, shell)
587	587	try:

0 commit comments

Comments

0 (0)