FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing main...feature/roadmap-commit-3 · rowkeydb-com/zetasketch-cpp · GitHub

/ zetasketch-cpp Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rowkeydb-com/zetasketch-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: rowkeydb-com/zetasketch-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/roadmap-commit-3
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 5, 2026

  1. fix: use correct coverage instrumentation filter 

    The previous instrumentation filter ('^//src,^//include,-^//src/farmhash')
failed to match the root library target ('//:zetasketch-cpp') due to
wildcard expansion rules in Bazel when matching labels. This caused the
root library to remain un-instrumented in CI.

Because no targets were instrumented, the coverage test actions matched
the standard 'bazel test' action keys, hitting the test cache. Standard
test execution does not produce 'coverage.dat' artifacts, resulting in
LcovMerger failing with 'There was no coverage found'.

This commit replaces the filter with '^//[^/]*:.*$' (identical to the
rowkeydb repository configuration). This correctly matches all top-level
targets (including the root library) while implicitly excluding
sub-packages (such as '//src/farmhash:farmhash'). This ensures
coverage profiling is correctly generated for the root library without
requiring the '--nocache_test_results' workaround.
    marete committed Aug 5, 2026
    Configuration menu
    Copy the full SHA
    01dec07 View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL