This repository was archived by the owner on Jul 22, 2023. It is now read-only.
Commit b85104b
Fixed crash due to unnecessary decref of a borrowed reference in params array handling (pythonnet#1163)
1 parent 8e8f205 commit b85104b
2 files changed
Lines changed: 3 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -13,7 +13,8 @@ This document follows the conventions laid out in [Keep a CHANGELOG][]. | |||
| 13 | 13 | ||
| 14 | 14 | ### Fixed | |
| 15 | 15 | ||
| 16 | - - Fix incorrect dereference of wrapper object in tp_repr, which may result in a program crash | ||
| 16 | + - Fix incorrect dereference of wrapper object in `tp_repr`, which may result in a program crash | ||
| 17 | + - Fix incorrect dereference in params array handling | ||
| 17 | 18 | ||
| 18 | 19 | ## [2.5.0][] - 2020-06-14 | |
| 19 | 20 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -372,7 +372,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth | |||
| 372 | 372 | static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out bool isNewReference) | |
| 373 | 373 | { | |
| 374 | 374 | isNewReference = false; | |
| 375 | - IntPtr op; | ||
| 375 | + IntPtr op; | ||
| 376 | 376 | // for a params method, we may have a sequence or single/multiple items | |
| 377 | 377 | // here we look to see if the item at the paramIndex is there or not | |
| 378 | 378 | // and then if it is a sequence itself. | |
@@ -390,10 +390,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out | |||
| 390 | 390 | { | |
| 391 | 391 | isNewReference = true; | |
| 392 | 392 | op = Runtime.PyTuple_GetSlice(args, arrayStart, pyArgCount); | |
| 393 | - if (item != IntPtr.Zero) | ||
| 394 | - { | ||
| 395 | - Runtime.XDecref(item); | ||
| 396 | - } | ||
| 397 | 393 | } | |
| 398 | 394 | } | |
| 399 | 395 | else | |
0 commit comments