Properly detect min and max element in array (#224) · sdwlig/javascript-algorithms@6bd6072 · GitHub

1. sdwlig
2. javascript-algorithms

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 6bd6072

Browse filesBrowse the repository at this point in the historyBrowse files

Yavorski

authored and

trekhleb

committed

Properly detect min and max element in array (trekhleb#224)

1 parent 5d12638 commit 6bd6072
Copy full SHA for 6bd6072

1 file changed

+2-6Lines changed: 2 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/algorithms/sorting/counting-sort/__test__
  • CountingSort.test.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/algorithms/sorting/counting-sort/__test__/CountingSort.test.js‎

Copy file name to clipboardExpand all lines: src/algorithms/sorting/counting-sort/__test__/CountingSort.test.js

+2-6Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -27,14 +27,10 @@ describe('CountingSort', () => {
27	27	const sorter = new CountingSort({ visitingCallback });
28	28
29	29	// Detect biggest number in array in prior.
30		- const biggestElement = notSortedArr.reduce((accumulator, element) => {
31		- return element > accumulator ? element : accumulator;
32		- }, 0);
	30	+ const biggestElement = Math.max(...notSortedArr);
33	31
34	32	// Detect smallest number in array in prior.
35		- const smallestElement = notSortedArr.reduce((accumulator, element) => {
36		- return element < accumulator ? element : accumulator;
37		- }, 0);
	33	+ const smallestElement = Math.min(...notSortedArr);
38	34
39	35	const sortedArray = sorter.sort(notSortedArr, smallestElement, biggestElement);
40	36

0 commit comments

Comments

0 (0)