FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing master...fix/homedepot-timeout · serpapi/serpapi-java · GitHub

/ serpapi-java Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serpapi/serpapi-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: serpapi/serpapi-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/homedepot-timeout
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 16, 2026

  1. fix: apply the client timeout to reading, not just connecting 

    HomeDepotTest failed 4 of the last 7 CI runs, always the same way:

  SerpApiException: java.net.http.HttpTimeoutException: request timed out

SerpApi.timeout was wired only to setHttpConnectionTimeout, so the read
timeout was never configured and kept SerpApiHttp's 60s default. That is
backwards: a 60s connection timeout is meaningless, since connecting
takes milliseconds, while 60s to read is tight for engines that scrape.
Apply the timeout to both, and raise the default to 120s, which the
home_depot engine regularly needs.

This is a library fix rather than a test fix: any caller searching a slow
engine hit the same timeout.

Also repair the README snippet helper, which sliced examples at a
hardcoded lines[23..], assuming every example body starts at line 24.
Quarantining GoogleEventsTest shifted that file and pulled the @ignore
and its comment into the docs as if they were usage code. Anchor on the
"// setup serpapi client" marker instead, which every example test has
exactly once, and regenerate.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    jvmvik and claude committed Aug 16, 2026
    Configuration menu
    Copy the full SHA
    dc80202 View commit details
    Browse the repository at this point in the history

  2. chore: remove stray empty file 

    Created accidentally by a shell redirect run from the wrong directory.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
    jvmvik and claude committed Aug 16, 2026
    Configuration menu
    Copy the full SHA
    ea6331b View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL