Try the ptrhash feature from phf - #307
Draft
SimonSapin wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Simon Sapin <simon@igalia.com>
rust-phf/rust-phf#392 rust-phf/rust-phf#349 Signed-off-by: Simon Sapin <simon@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-phf/rust-phf#392 and rust-phf/rust-phf#349
Fixes #31
This goes on top of #306
To run benchmarks:
The results on my desktop machine are mixed, I’m not sure what to make of them:
static_atom intern time: [18.177 ns 18.283 ns 18.399 ns] change: [−26.752% −26.353% −25.942%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 3 (3.00%) high mild static_atom as_str ×1000 time: [488.64 ns 495.40 ns 501.82 ns] change: [+11.981% +14.462% +16.911%] (p = 0.00 < 0.05) Performance has regressed. short_inline_atom intern time: [8.2140 ns 8.2437 ns 8.2728 ns] change: [−0.9334% −0.2491% +0.3623%] (p = 0.47 > 0.05) No change in performance detected. short_inline_atom as_str ×1000 time: [468.30 ns 469.63 ns 471.06 ns] change: [−0.7047% −0.1391% +0.4225%] (p = 0.63 > 0.05) No change in performance detected. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild medium_inline_atom intern time: [8.4393 ns 8.4672 ns 8.4977 ns] change: [+0.1231% +0.6802% +1.2484%] (p = 0.02 < 0.05) Change within noise threshold. medium_inline_atom as_str ×1000 time: [468.63 ns 470.26 ns 471.94 ns] change: [−0.7374% −0.1749% +0.3837%] (p = 0.55 > 0.05) No change in performance detected. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild min_dynamic_atom intern time: [60.353 ns 60.624 ns 60.895 ns] change: [−10.002% −8.5817% −7.5724%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 3 (3.00%) high mild min_dynamic_atom as_str ×1000 time: [275.20 ns 299.50 ns 326.12 ns] change: [+0.3170% +10.220% +20.425%] (p = 0.04 < 0.05) Change within noise threshold. longer_dynamic_atom intern time: [100.59 ns 100.99 ns 101.40 ns] change: [+32.264% +33.042% +33.859%] (p = 0.00 < 0.05) Performance has regressed. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild longer_dynamic_atom as_str ×1000 time: [274.90 ns 299.56 ns 326.75 ns] change: [+0.5408% +10.256% +20.929%] (p = 0.04 < 0.05) Change within noise threshold.