Commit 9f7befe
Fail closed on pause contributions workflow
In the original workflow, I had `catch(err) => false`.
But during code review the question was raised:
What happens if we get rate limited and all the requests from the API fail?
(E.g. if we do a script and automatically create PRs across all of Exercism, which is totally a thing).
We were like: ooh, that would suck, wouldn’t it? It would be better if we occasionally had to deal with manually closing a PR.
But here’s the kicker. The API response has no body. It’s either 204 or 404, where 404 is perceived as… an error.
So I changed it, and (importantly) forgot to test the script one final time.
So here is a version that will actually work. (I tested.)1 parent 3b7ac87 commit 9f7befe
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -30,7 +30,7 @@ jobs: | |||
| 30 | 30 | org: context.repo.owner, | |
| 31 | 31 | username: context.actor, | |
| 32 | 32 | }).then(response => response.status == 204) | |
| 33 | - .catch(err => true); | ||
| 33 | + .catch(err => false); | ||
| 34 | 34 | - name: Comment | |
| 35 | 35 | if: steps.is-organization-member.outputs.result == 'false' | |
| 36 | 36 | uses: actions/github-script@d556feaca394842dc55e4734bf3bb9f685482fa0 | |
0 commit comments