Don't call static methods through an instance. NFC. · solvespace/solvespace@34dccbf · GitHub

solvespace / solvespace Public

• Notifications You must be signed in to change notification settings
• Fork 600
• Star 4.2k

• Code
• Issues 255
• Pull requests 36
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 34dccbf

Browse filesBrowse the repository at this point in the historyBrowse files

rpavlik

authored and

whitequark

committed

Don't call static methods through an instance. NFC.

Found by clang-tidy.

1 parent 219df31 commit 34dccbf
Copy full SHA for 34dccbf

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • exportvector.cpp
  • platform
    • guigtk.cpp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/exportvector.cpp‎

Copy file name to clipboardExpand all lines: src/exportvector.cpp

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -325,7 +325,7 @@ class DxfWriteInterface : public DRW_Interface {
325	325
326	326	void assignEntityDefaults(DRW_Entity *entity, hStyle hs) {
327	327	Style *s = Style::Get(hs);
328		- RgbaColor color = s->Color(hs, /*forExport=*/true);
	328	+ RgbaColor color = Style::Color(hs, /*forExport=*/true);
329	329	entity->color24 = color.ToPackedIntBGRA();
330	330	entity->color = findDxfColor(color);
331	331	entity->layer = s->DescriptionString();

Collapse file

‎src/platform/guigtk.cpp‎

Copy file name to clipboardExpand all lines: src/platform/guigtk.cpp

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1471,11 +1471,11 @@ void InitGui(int argc, char **argv) {
1471	1471	}
1472	1472
1473	1473	void RunGui() {
1474		- gtkMain->run();
	1474	+ Gtk::Main::run();
1475	1475	}
1476	1476
1477	1477	void ExitGui() {
1478		- gtkMain->quit();
	1478	+ Gtk::Main::quit();
1479	1479	}
1480	1480
1481	1481	void ClearGui() {

0 commit comments

Comments

0 (0)