fix: hoverMessage now properly renders as a tooltip · sourcegraph/browser-extensions@c7409d3 · GitHub

This repository was archived by the owner on Jan 22, 2019. It is now read-only.

sourcegraph / browser-extensions Public archive

• Notifications You must be signed in to change notification settings
• Fork 15
• Star 49

• Code
• Issues
• Pull requests 18
• Actions
• Security and quality
• Insights

Additional navigation options

Commit c7409d3

Browse filesBrowse the repository at this point in the historyBrowse files

Stephen Gutekanst

committed

fix: hoverMessage now properly renders as a tooltip

Prior to this change, extensions such as code discussions would specify a `DecorationAttachmentRenderingOptions.hoverMessage` but it would only work on Sourcegraph, it was unused in the browser extension. Now it renders as a native browser tooltip, which is okay for most cases. Fixes sourcegraph/sourcegraph-extension-api#107

1 parent 2836554 commit c7409d3
Copy full SHA for c7409d3

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/libs/code_intelligence
  • extensions.tsx

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/libs/code_intelligence/extensions.tsx‎

Copy file name to clipboardExpand all lines: src/libs/code_intelligence/extensions.tsx

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -193,6 +193,7 @@ export const applyDecoration = (
193	193	after.className = 'sourcegraph-extension-element'
194	194	after.style.backgroundColor = decoration.after.backgroundColor || null
195	195	after.textContent = decoration.after.contentText || null
	196	+ after.title = decoration.after.hoverMessage || ''
196	197
197	198	const annotation = decoration.after.linkURL ? linkTo(decoration.after.linkURL)(after) : after
198	199	codeElement.appendChild(annotation)

0 commit comments

Comments

0 (0)