fix: sync z-index for github tree and hover overlay (#278) · sourcegraph/browser-extensions@f195537 · GitHub

This repository was archived by the owner on Jan 22, 2019. It is now read-only.

sourcegraph / browser-extensions Public archive

• Notifications You must be signed in to change notification settings
• Fork 15
• Star 49

• Code
• Issues
• Pull requests 18
• Actions
• Security and quality
• Insights

Additional navigation options

Commit f195537

Browse filesBrowse the repository at this point in the historyBrowse files

lukeautry

authored and

ijsnow

committed

fix: sync z-index for github tree and hover overlay (#278)

Closes https://github.com/sourcegraph/sourcegraph/issues/242.

1 parent 58b64ce commit f195537
Copy full SHA for f195537

4 files changed

+9-3Lines changed: 9 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • libs
    • code_intelligence
      • HoverOverlay.scss
    • gitlab
      • style.scss
  • shared
    • global-styles
      • variables.scss
    • tree
      • tree.scss

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/libs/code_intelligence/HoverOverlay.scss‎

Copy file name to clipboardExpand all lines: src/libs/code_intelligence/HoverOverlay.scss

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,4 +1,5 @@
1	1	@import '../gitlab/style.scss';
	2	+ @import '../../global-styles/variables.scss';
2	3
3	4	.hover-overlay-mount__phabricator {
4	5	.hover-overlay {
@@ -18,3 +19,7 @@
18	19	}
19	20	}
20	21	}
	22	+
	23	+ .hover-overlay {
	24	+ z-index: $default-z-index;
	25	+ }

Collapse file

‎src/libs/gitlab/style.scss‎

Copy file name to clipboardExpand all lines: src/libs/gitlab/style.scss

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,5 @@
1	1	.hover-overlay-mount__gitlab {
2	2	.hover-overlay {
3		- z-index: 999;
4		-
5	3	code {
6	4	background: none;
7	5	color: unset;

Collapse file

‎src/shared/global-styles/variables.scss‎

Copy file name to clipboard

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1 @@
	1	+ $default-z-index: 2000;

Collapse file

‎src/shared/tree/tree.scss‎

Copy file name to clipboardExpand all lines: src/shared/tree/tree.scss

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,8 +1,10 @@
	1	+ @import '../global-styles/variables.scss';
	2	+
1	3	.tree-mount {
2	4	position: fixed;
3	5	top: 0;
4	6	left: 0;
5		- z-index: 2000;
	7	+ z-index: $default-z-index - 1;
6	8	width: 100%;
7	9	pointer-events: none;
8	10	height: 100%;

0 commit comments

Comments

0 (0)