FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merged revision 3870 from 0.9 branch: · sqlobject/sqlobject@4fc350f · GitHub

Commit 4fc350f

Browse files
committed
Merged revision 3870 from 0.9 branch:
a bug in SQLiteConnection.columnsFromSchema() that led to an infinite loop was fixed. git-svn-id: http://svn.colorstudy.com/SQLObject/trunk@3872 95a46c32-92d2-0310-94a5-8d71aeb3d4b3
1 parent 9a65bcf commit 4fc350f

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎docs/News.txt‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,9 @@ SQLObject 0.9.10
188188
without this calling Transaction.close() calls connection.close() which
189189
is wrong.
190190

191+
* A bug in SQLiteConnection.columnsFromSchema() that led to an infinite
192+
loop was fixed.
193+
191194
SQLObject 0.9.9
192195
===============
193196

‎sqlobject/sqlite/sqliteconnection.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,11 @@ def _columnsFromSchemaParse(self, tableName, soClass):
313313
if not colData:
314314
raise ValueError('The table %s was not found in the database. Load failed.' % tableName)
315315
colData = colData[0].split('(', 1)[1].strip()[:-2]
316-
while colData.find('(') > -1:
316+
while True:
317317
start = colData.find('(')
318+
if start == -1: break
318319
end = colData.find(')', start)
320+
if end == -1: break
319321
colData = colData[:start] + colData[end+1:]
320322
results = []
321323
for colDesc in colData.split(','):

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL