rstudio/src/cpp/core/DatabaseTests.cpp at main · ssh352/rstudio · GitHub

History

579 lines (478 loc) · 20.7 KB

Raw

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

426

427

428

429

430

431

432

433

434

435

436

437

438

439

440

441

442

443

444

445

446

447

448

449

450

451

452

453

454

455

456

457

458

459

460

461

462

463

464

465

466

467

468

469

470

471

472

473

474

475

476

477

478

479

480

481

482

483

484

485

486

487

488

489

490

491

492

493

494

495

496

497

498

499

500

501

502

503

504

505

506

507

508

509

510

511

512

513

514

515

516

517

518

519

520

521

522

523

524

525

526

527

528

529

530

531

532

533

534

535

536

537

538

539

540

541

542

543

544

545

546

547

548

549

550

551

552

553

554

555

556

557

558

559

560

561

562

563

564

565

566

567

568

569

570

571

572

573

574

575

576

577

578

579

* DatabaseTests.cpp

* Unless you have received this program directly from Posit Software pursuant

* to the terms of a commercial license agreement with Posit Software, then

* this program is licensed to you under the terms of version 3 of the

* GNU Affero General Public License. This program is distributed WITHOUT

* ANY EXPRESS OR IMPLIED WARRANTY, INCLUDING THOSE OF NON-INFRINGEMENT,

* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. Please refer to the

* AGPL (http://www.gnu.org/licenses/agpl-3.0.txt) for more details.

#include <tests/TestThat.hpp>

#include <core/Database.hpp>

#include <core/FileSerializer.hpp>

#include <core/system/System.hpp>

#include <shared_core/SafeConvert.hpp>

#include <soci/session.h>

#include <soci/sqlite3/soci-sqlite3.h>

#include "config.h"

namespace rstudio {

namespace unit_tests {

using namespace core;

using namespace core::database;

core::database::SqliteConnectionOptions sqliteConnectionOptions()

{

return SqliteConnectionOptions { "/tmp/rstudio-test-db" };

}

core::database::PostgresqlConnectionOptions postgresConnectionOptions()

{

PostgresqlConnectionOptions options;

options.connectionTimeoutSeconds = 10;

options.database = "rstudio-test";

options.host = "localhost";

options.username = "postgres";

options.password = "postgres";

return options;

}

TEST_CASE("Database", "[.database]")

{

test_that("Test Setup")

{

// ensure that the test databases do not exist

FilePath sqliteDbPath("/tmp/rstudio-test-db");

sqliteDbPath.removeIfExists();

boost::shared_ptr<IConnection> connection;

Error error = connect(postgresConnectionOptions(), &connection);

if (error)

return;

std::string queryStr =

R""(

DROP SCHEMA public CASCADE;

CREATE SCHEMA public;

GRANT ALL ON SCHEMA public TO postgres;

GRANT ALL ON SCHEMA public TO public;

)"";

connection->executeStr(queryStr);

}

test_that("Can create SQLite database")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &connection));

Query query = connection->query("create table Test(id int, text varchar(255))");

REQUIRE_FALSE(connection->execute(query));

int id = 10;

std::string text = "Hello, database!";

query = connection->query("insert into Test(id, text) values(:id, :text)")

.withInput(id)

.withInput(text);

REQUIRE_FALSE(connection->execute(query));

int rowId;

std::string rowText;

query = connection->query("select id, text from Test where id = (:id)")

.withInput(id)

.withOutput(rowId)

.withOutput(rowText);

REQUIRE_FALSE(connection->execute(query));

CHECK(rowId == id);

CHECK(rowText == text);

}

test_that("Can create PostgreSQL database")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(postgresConnectionOptions(), &connection));

Query query = connection->query("create table Test(id int, text varchar(255))");

REQUIRE_FALSE(connection->execute(query));

int id = 10;

std::string text = "Hello, database!";

query = connection->query("insert into Test(id, text) values(:id, :text)")

.withInput(id)

.withInput(text);

REQUIRE_FALSE(connection->execute(query));

int rowId;

std::string rowText;

query = connection->query("select id, text from Test where id = (:id)")

.withInput(id)

.withOutput(rowId)

.withOutput(rowText);

REQUIRE_FALSE(connection->execute(query));

CHECK(rowId == id);

CHECK(rowText == text);

}

test_that("Can perform transactions")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &connection));

Transaction transaction(connection);

int numFailed = 0;

bool dataReturned = false;

// verify that we can commit a transaction

Query query = connection->query("insert into Test(id, text) values(:id, :text)");

for (int id = 0; id < 100; ++id)

{

std::string text = "Test text " + core::safe_convert::numberToString(id);

query.withInput(id).withInput(text);

if (connection->execute(query))

++numFailed;

}

REQUIRE(numFailed == 0);

transaction.commit();

int rowId;

std::string rowText;

query = connection->query("select id, text from Test where id = 50")

.withOutput(rowId)

.withOutput(rowText);

REQUIRE_FALSE(connection->execute(query, &dataReturned));

REQUIRE(dataReturned);

REQUIRE(rowId == 50);

REQUIRE(rowText == "Test text 50");

// now attempt to rollback a transaction

Transaction transaction2(connection);

query = connection->query("insert into Test(id, text) values(:id, :text)");

for (int id = 100; id < 200; ++id)

{

std::string text = "Test text " + core::safe_convert::numberToString(id);

query.withInput(id).withInput(text);

if (connection->execute(query))

++numFailed;

}

REQUIRE(numFailed == 0);

transaction2.rollback();

query = connection->query("select id, text from Test where id = 150")

.withOutput(rowId)

.withOutput(rowText);

// expect no data

REQUIRE_FALSE(connection->execute(query, &dataReturned));

REQUIRE_FALSE(dataReturned);

}

test_that("Can bulk select")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &connection));

Rowset rows;

Query query = connection->query("select id, text from Test where id >= 50 and id <= 100");

REQUIRE_FALSE(connection->execute(query, rows));

int i = 0;

for (RowsetIterator it = rows.begin(); it != rows.end(); ++it)

{

Row& row = *it;

REQUIRE(row.get<int>(0) == i + 50);

REQUIRE(row.get<std::string>(1) == "Test text " + safe_convert::numberToString(i+50));

++i;

}

test_that("Can bulk insert")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &connection));

std::vector<int> rowIds {1000, 2000, 3000, 4000, 5000};

std::vector<std::string> rowTexts {"1000", "2000", "3000", "4000", "5000"};

Query query = connection->query("insert into Test values (:id, :txt)")

.withInput(rowIds)

.withInput(rowTexts);

REQUIRE_FALSE(connection->execute(query));

Query selectQuery = connection->query("select * from Test where id >= 1000");

Rowset rowset;

REQUIRE_FALSE(connection->execute(selectQuery, rowset));

int i = 1;

for (RowsetIterator it = rowset.begin(); it != rowset.end(); ++it)

{

Row& row = *it;

REQUIRE(row.get<int>(0) == i * 1000);

REQUIRE(row.get<std::string>(1) == safe_convert::numberToString(i*1000));

++i;

}

test_that("Can use connection pool")

{

boost::shared_ptr<ConnectionPool> connectionPool;

REQUIRE_FALSE(createConnectionPool(5, sqliteConnectionOptions(), &connectionPool));

boost::shared_ptr<IConnection> connection = connectionPool->getConnection();

int rowId;

std::string rowText;

Query query = connection->query("select id, text from Test where id = 50")

.withOutput(rowId)

.withOutput(rowText);

bool dataReturned = false;

REQUIRE_FALSE(connection->execute(query, &dataReturned));

REQUIRE(dataReturned);

boost::shared_ptr<IConnection> connection2 = connectionPool->getConnection();

Query query2 = connection2->query("select id, text from Test where id = 25")

.withOutput(rowId)

.withOutput(rowText);

dataReturned = false;

REQUIRE_FALSE(connection2->execute(query2, &dataReturned));

REQUIRE(dataReturned);

}

test_that("Can update schemas")

{

// generate some schema files

std::string schema1 =

R""(

CREATE TABLE TestTable1_Persons(

id int NOT NULL,

first_name varchar(255),

last_name varchar(255) NOT NULL,

email_address varchar(255)

);

CREATE TABLE TestTable2_AccountHolders(

id int,

fk_person_id int

);

)"";

// sqlite cannot alter tables very well, so adding constraints necessitates dropping

// and re-creating the tables

std::string schema2Sqlite =

R""(

CREATE TABLE TestTable1_Persons_new(

id int NOT NULL,

first_name varchar(255),

last_name varchar(255),

email_address varchar(255),

PRIMARY KEY (id)

);

DROP TABLE TestTable1_Persons;

ALTER TABLE TestTable1_Persons_new RENAME TO TestTable1_Persons;

CREATE TABLE TestTable2_AccountHolders_new(

id int,

fk_person_id int,

PRIMARY KEY (id),

FOREIGN KEY (fk_person_id) REFERENCES TestTable1_Persons(id)

);

DROP TABLE TestTable2_AccountHolders;

ALTER TABLE TestTable2_AccountHolders_new RENAME TO TestTable2_AccountHolders;

)"";

// postgresql supports modification of tables

std::string schema2Postgresql =

R""(

ALTER TABLE TestTable1_Persons

ADD PRIMARY KEY (id);

ALTER TABLE TestTable2_AccountHolders

ADD PRIMARY KEY (id);

ALTER TABLE TestTable2_AccountHolders

ADD FOREIGN KEY (fk_person_id) REFERENCES TestTable1_Persons(id);

)"";

std::string schema3Sqlite =

R""(

CREATE TABLE TestTable2_AccountHolders_new(

id int,

fk_person_id int,

creation_time text,

PRIMARY KEY (id),

FOREIGN KEY (fk_person_id) REFERENCES TestTable1_Persons(id)

);

DROP TABLE TestTable2_AccountHolders;

ALTER TABLE TestTable2_AccountHolders_new RENAME TO TestTable2_AccountHolders;

)"";

std::string schema3Postgresql =

R""(

ALTER TABLE TestTable2_AccountHolders

ADD COLUMN creation_time text;

)"";

FilePath workingDir = core::system::currentWorkingDir(core::system::currentProcessId());

FilePath outFile1 = workingDir.completeChildPath("1_InitialTables.sql");

FilePath outFile2Sqlite = workingDir.completeChildPath("2_ConstraintsForInitialTables.sqlite");

FilePath outFile2Postgresql = workingDir.completeChildPath("2_ConstraintsForInitialTables.postgresql");

FilePath outFile3Sqlite = workingDir.completeChildPath("3_AddAccountCreationTime.sqlite");

FilePath outFile3Postgresql = workingDir.completeChildPath("3_AddAccountCreationTime.postgresql");

REQUIRE_FALSE(writeStringToFile(outFile1, schema1));

REQUIRE_FALSE(writeStringToFile(outFile2Sqlite, schema2Sqlite));

REQUIRE_FALSE(writeStringToFile(outFile2Postgresql, schema2Postgresql));

REQUIRE_FALSE(writeStringToFile(outFile3Sqlite, schema3Sqlite));

REQUIRE_FALSE(writeStringToFile(outFile3Postgresql, schema3Postgresql));

boost::shared_ptr<IConnection> sqliteConnection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &sqliteConnection));

boost::shared_ptr<IConnection> postgresConnection;

REQUIRE_FALSE(connect(postgresConnectionOptions(), &postgresConnection));

SchemaUpdater sqliteUpdater(sqliteConnection, workingDir);

SchemaUpdater postgresUpdater(postgresConnection, workingDir);

REQUIRE_FALSE(sqliteUpdater.update());

REQUIRE_FALSE(postgresUpdater.update());

SchemaVersion currentSchemaVersion;

REQUIRE_FALSE(sqliteUpdater.databaseSchemaVersion(&currentSchemaVersion));

REQUIRE(currentSchemaVersion == SchemaVersion("3", RSTUDIO_RELEASE_NAME));

currentSchemaVersion = SchemaVersion();

REQUIRE_FALSE(postgresUpdater.databaseSchemaVersion(&currentSchemaVersion));

REQUIRE(currentSchemaVersion == SchemaVersion("3", RSTUDIO_RELEASE_NAME));

// ensure repeated calls to update work without error

REQUIRE_FALSE(sqliteUpdater.update());

REQUIRE_FALSE(postgresUpdater.update());

// ensure we can insert data as expected (given our expected constraints)

int id = 1;

std::string firstName = "Billy";

std::string lastName = "Joel";

std::string email = "bjoel@example.com";

std::string creationTime = "03/03/2020 12:00:00";

// create queries - we will be executing them multiple times, so bind input just before execution

Query sqliteInsertQuery = sqliteConnection->query("INSERT INTO TestTable1_Persons VALUES (:id, :fname, :lname, :email)");

Query postgresInsertQuery = postgresConnection->query("INSERT INTO TestTable1_Persons VALUES (:id, :fname, :lname, :email)");

Query sqliteInsertQuery2 = sqliteConnection->query("INSERT INTO TestTable2_AccountHolders VALUES (:id, :pid, :time)");

Query postgresInsertQuery2 = postgresConnection->query("INSERT INTO TestTable2_AccountHolders VALUES (:id, :pid, :time)");

// should fail - FK constraint

sqliteInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

postgresInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

CHECK(sqliteConnection->execute(sqliteInsertQuery2));

CHECK(postgresConnection->execute(postgresInsertQuery2));

// should succeed - properly ordered

sqliteInsertQuery

.withInput(id, "id")

.withInput(firstName, "fname")

.withInput(lastName, "lname")

.withInput(email, "email");

CHECK_FALSE(sqliteConnection->execute(sqliteInsertQuery));

sqliteInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

CHECK_FALSE(sqliteConnection->execute(sqliteInsertQuery2));

postgresInsertQuery

.withInput(id, "id")

.withInput(firstName, "fname")

.withInput(lastName, "lname")

.withInput(email, "email");

CHECK_FALSE(postgresConnection->execute(postgresInsertQuery));

postgresInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

CHECK_FALSE(postgresConnection->execute(postgresInsertQuery2));

// should fail - PK constraint

sqliteInsertQuery

.withInput(id, "id")

.withInput(firstName, "fname")

.withInput(lastName, "lname")

.withInput(email, "email");

CHECK(sqliteConnection->execute(sqliteInsertQuery));

sqliteInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

CHECK(sqliteConnection->execute(sqliteInsertQuery2));

postgresInsertQuery

.withInput(id, "id")

.withInput(firstName, "fname")

.withInput(lastName, "lname")

.withInput(email, "email");

CHECK(postgresConnection->execute(postgresInsertQuery));

postgresInsertQuery2

.withInput(id, "id")

.withInput(id, "pid")

.withInput(creationTime, "time");

CHECK(postgresConnection->execute(postgresInsertQuery2));

}

test_that("Schema Version comparisons are correct")

{

std::vector<SchemaVersion> versions {

{},

{"", "20200226141952248123456_AddRevokedCookie"},

{"Ghost Orchid", "20210712182145921760944"},

{"Prairie Trillium", "20210916132211194382021"},

{"Aphid", "21210916132211194382021"}

};

for(int i=0; i < (int) versions.size(); i++)

{

//Compare against smaller

for(int j=0; j < i; j++){

REQUIRE(versions[j] < versions[i]);

REQUIRE_FALSE(versions[j] > versions[i]);

REQUIRE(versions[j] <= versions[i]);

}

SchemaVersion sameVersion(versions[i]);

REQUIRE(sameVersion == versions[i]);

//Compare against larger

for(int j=i+1; j < (int) versions.size(); j++)

{

REQUIRE(versions[i] < versions[j]);

REQUIRE_FALSE(versions[i] > versions[j]);

REQUIRE(versions[i] <= versions[j]);

}

test_that("Can execute str with multiple queries")

{

boost::shared_ptr<IConnection> connection;

REQUIRE_FALSE(connect(sqliteConnectionOptions(), &connection));

std::string queryStr =

"CREATE TABLE TestTable_3("

"A text, B text\n); \n"

"INSERT INTO TestTable_3 VALUES (\"Hello\", \"World; \");\n"

"INSERT INTO TestTable_3 VALUES (\"Hello2\", \";;;\");";

REQUIRE_FALSE(connection->executeStr(queryStr));

Query selectQuery = connection->query("select * from TestTable_3 order by A asc");

Rowset rowset;

REQUIRE_FALSE(connection->execute(selectQuery, rowset));

int i = 0;

std::string vals[2][2];

vals[0][0] = "Hello";

vals[0][1] = "World; ";

vals[1][0] = "Hello2";

vals[1][1] = ";;;";

for (RowsetIterator it = rowset.begin(); it != rowset.end(); ++it)

{

Row& row = *it;

REQUIRE(row.get<std::string>(0) == vals[i][0]);

REQUIRE(row.get<std::string>(1) == vals[i][1]);

++i;

}

test_that("Can correctly parse postgresql connection URIs")

{

PostgresqlConnectionOptions options;

options.connectionUri = "bogus://not-a-uri";

CHECK(validateOptions(options, nullptr));

options.connectionUri = "postgresql://";

CHECK(validateOptions(options, nullptr));

std::string connectionStr;

options.connectionUri = "postgres://localhost";