Commit 6fbe511
committed
Show version and platform info in one place
Instead of splitting it in into two places where at least one of
the places is highly likely to be missed, this puts it together
just before the first steps that makes nontrivial use of the
installed packages. Grouping it together, it can't really be shown
earlier, because one of the pieces of information is obtained
using the git module (to examine that behavior of the code).
This also presents the information more clearly. "set -x" makes
this easy, so the commands are rewritten to take advantage of it.1 parent 45773c2 commit 6fbe511
2 files changed
Lines changed: 14 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -29,11 +29,6 @@ jobs: | |||
| 29 | 29 | with: | |
| 30 | 30 | packages: python39 python39-pip python39-virtualenv git | |
| 31 | 31 | ||
| 32 | - - name: Show python and git versions | ||
| 33 | - run: | | ||
| 34 | - /usr/bin/python --version | ||
| 35 | - /usr/bin/git version | ||
| 36 | - | ||
| 37 | 32 | - name: Tell git to trust this repo | |
| 38 | 33 | run: | | |
| 39 | 34 | /usr/bin/git config --global --add safe.directory "$(pwd)" | |
@@ -58,9 +53,13 @@ jobs: | |||
| 58 | 53 | run: | | |
| 59 | 54 | /usr/bin/python -m pip install ".[test]" | |
| 60 | 55 | ||
| 61 | - - name: Check 'is_win' | ||
| 56 | + - name: Show version and platform information | ||
| 62 | 57 | run: | | |
| 63 | - /usr/bin/python -c 'import os, git; print(f"os.name={os.name}, is_win={git.compat.is_win}")' | ||
| 58 | + /usr/bin/git version | ||
| 59 | + /usr/bin/python --version | ||
| 60 | + /usr/bin/python -c 'import sys; print(sys.platform)' | ||
| 61 | + /usr/bin/python -c 'import os; print(os.name)' | ||
| 62 | + /usr/bin/python -c 'import git; print(git.compat.is_win)' | ||
| 64 | 63 | ||
| 65 | 64 | - name: Test with pytest | |
| 66 | 65 | run: | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,11 +36,6 @@ jobs: | |||
| 36 | 36 | python-version: ${{ matrix.python-version }} | |
| 37 | 37 | allow-prereleases: ${{ matrix.experimental }} | |
| 38 | 38 | ||
| 39 | - - name: Show python and git versions | ||
| 40 | - run: | | ||
| 41 | - python --version | ||
| 42 | - git version | ||
| 43 | - | ||
| 44 | 39 | - name: Prepare this repo for tests | |
| 45 | 40 | run: | | |
| 46 | 41 | TRAVIS=yes ./init-tests-after-clone.sh | |
@@ -66,17 +61,21 @@ jobs: | |||
| 66 | 61 | run: | | |
| 67 | 62 | pip install ".[test]" | |
| 68 | 63 | ||
| 64 | + - name: Show version and platform information | ||
| 65 | + run: | | ||
| 66 | + git version | ||
| 67 | + python --version | ||
| 68 | + python -c 'import sys; print(sys.platform)' | ||
| 69 | + python -c 'import os; print(os.name)' | ||
| 70 | + python -c 'import git; print(git.compat.is_win)' | ||
| 71 | + | ||
| 69 | 72 | - name: Check types with mypy | |
| 70 | 73 | run: | | |
| 71 | 74 | mypy -p git | |
| 72 | 75 | # With new versions of mypy new issues might arise. This is a problem if there is nobody able to fix them, | |
| 73 | 76 | # so we have to ignore errors until that changes. | |
| 74 | 77 | continue-on-error: true | |
| 75 | 78 | ||
| 76 | - - name: Check 'is_win' | ||
| 77 | - run: | | ||
| 78 | - python -c 'import os, git; print(f"os.name={os.name}, is_win={git.compat.is_win}")' | ||
| 79 | - | ||
| 80 | 79 | - name: Test with pytest | |
| 81 | 80 | run: | | |
| 82 | 81 | pytest -v | |
0 commit comments