fix: sync relationship changes for users not in the local cache (#189) · stoatchat/javascript-client-sdk@119107b · GitHub

stoatchat / javascript-client-sdk Public

• Notifications You must be signed in to change notification settings
• Fork 108
• Star 285

• Code
• Issues 11
• Pull requests 13
• Actions
• Security and quality
• Insights

Additional navigation options

Commit 119107b

Browse filesBrowse the repository at this point in the historyBrowse files

aashish00021

authored

fix: sync relationship changes for users not in the local cache (#189)

UserRelationship events are re-dispatched as UserUpdate, which only applies changes to users already present in the collection (getOrPartial returns undefined for unknown ids when partials are disabled, the default). As a result, a relationship change (friend request accepted/received, block, unblock, etc.) made on another client is silently dropped on this client if it has never cached that user, until the next full resync. Ensure the user exists in the collection via getOrCreate using the data already included in the event, matching how Ready hydrates users on initial sync. Signed-off-by: aashish00021 <aashishbhardwaj07@icloud.com>

1 parent d435932 commit 119107b
Copy full SHA for 119107b

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/events
  • v1.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/events/v1.ts‎

Copy file name to clipboardExpand all lines: src/events/v1.ts

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -905,6 +905,10 @@ export async function handleEvent(
905	905	break;
906	906	}
907	907	case "UserRelationship": {
	908	+ // Live UserUpdate events are dropped for unknown users (see UserUpdate
	909	+ // below), so make sure this user exists in the cache before delegating.
	910	+ client.users.getOrCreate(event.user._id, event.user);
	911	+
908	912	handleEvent(
909	913	client,
910	914	{

0 commit comments

Comments

0 (0)