Fix Bug: .NetFramework 4.8 ClientWebSocket Cann't Connect To .Net8 Ws… · stratdev3/NetCoreServer@fcbbcb7 · GitHub

1. stratdev3
2. NetCoreServer

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit fcbbcb7

Browse filesBrowse the repository at this point in the historyBrowse files

chronoxor

committed

Fix Bug: .NetFramework 4.8 ClientWebSocket Cann't Connect To .Net8 WsSession chronoxor#278

1 parent 03a81a2 commit fcbbcb7
Copy full SHA for fcbbcb7

2 files changed

+2-9Lines changed: 2 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• source/NetCoreServer
  • NetCoreServer.csproj
  • WebSocket.cs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎source/NetCoreServer/NetCoreServer.csproj‎

Copy file name to clipboardExpand all lines: source/NetCoreServer/NetCoreServer.csproj

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -2,7 +2,7 @@
2	2
3	3	<PropertyGroup>
4	4	<TargetFramework>net8.0</TargetFramework>
5		- <Version>8.0.5.0</Version>
	5	+ <Version>8.0.6.0</Version>
6	6	<Authors>Ivan Shynkarenka</Authors>
7	7	<Copyright>Copyright (c) 2019-2023 Ivan Shynkarenka</Copyright>
8	8	<RepositoryUrl>https://github.com/chronoxor/NetCoreServer</RepositoryUrl>

Collapse file

‎source/NetCoreServer/WebSocket.cs‎

Copy file name to clipboardExpand all lines: source/NetCoreServer/WebSocket.cs

+1-8Lines changed: 1 addition & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -159,14 +159,7 @@ public bool PerformServerUpgrade(HttpRequest request, HttpResponse response)
159	159
160	160	if (string.Compare(key, "Connection", StringComparison.OrdinalIgnoreCase) == 0)
161	161	{
162		- var values = value.Split(',').Select(str => str.Trim()).ToArray();
163		- if ((values.Length == 0) ||
164		- ((values.Length == 1) && (string.Compare(values[0], "Upgrade", StringComparison.OrdinalIgnoreCase) != 0)) ||
165		- ((values.Length == 2) && !(
166		- ((string.Compare(values[0], "Upgrade", StringComparison.OrdinalIgnoreCase) == 0) && (string.Compare(values[1], "keep-alive", StringComparison.OrdinalIgnoreCase) == 0)) ||
167		- ((string.Compare(values[0], "keep-alive", StringComparison.OrdinalIgnoreCase) == 0) && (string.Compare(values[1], "Upgrade", StringComparison.OrdinalIgnoreCase) == 0))
168		- )) ||
169		- (values.Length > 2))
	162	+ if ((string.Compare(value, "Upgrade", StringComparison.OrdinalIgnoreCase) != 0) && (string.Compare(value.RemoveWhiteSpace(), "keep-alive,Upgrade", StringComparison.OrdinalIgnoreCase) != 0))
170	163	{
171	164	error = true;
172	165	response.MakeErrorResponse(400, "Invalid WebSocket handshaked request: 'Connection' header value must be 'Upgrade' or 'Upgrade, keep-alive'");

0 commit comments

Comments

0 (0)