According to the NumPy docs for npt.assert_almost_equal:
It is recommended to use one of assert_allclose, assert_array_almost_equal_nulp or assert_array_max_ulp instead of this function for more consistent floating point comparisons.
Perhaps, we should migrate our tests accordingly?
To Do List
- Each test file correctly replaces all uses of npt.assert_almost_equal or npt.assert_array_almost_equal with its equivalent npt.assert_allclose (check with grep assert*_almost tests/*)
- When rtol=0 for npt.assert_allclose, simply omit this paramter and value since this is the default
- Ensure that npt.assert_allclose(actual, desired) and npt.assert_array_equal(actual, desired) always has the stumpy computed value as "actual" and the naive computation as "desired"
- Use atol=1.5e-07 rather than atol=1.5*10**-07
- Eventually, replace the ugly 1.5*10**-config.STUMPY_TEST_PRECISION with config.STUMPY_TEST_PRECISION = 1.5e-07 (in config.py)
- Replace comp with cmp
- Rename naive outputs to ref_ and stumpy-computed outputs to cmp_ (applies to npt.assert_array_equal too)
- Omit "Fixed # 1175" from PR title and initial comment (use "Related to # 1175" instead)
Reactions are currently unavailable
According to the NumPy docs for npt.assert_almost_equal:
Perhaps, we should migrate our tests accordingly?
To Do List