gh-130999: Fix globals() poisoning in test_traceback (gh-135030) · taegyunkim/cpython@31f0d6e · GitHub

1. taegyunkim
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 31f0d6e

Browse filesBrowse the repository at this point in the historyBrowse files

ambv

authored and

taegyunkim

committed

pythongh-130999: Fix globals() poisoning in test_traceback (pythongh-135030)

1 parent dfc5596 commit 31f0d6e
Copy full SHA for 31f0d6e

1 file changed

+5-4Lines changed: 5 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Lib/test
  • test_traceback.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Lib/test/test_traceback.py‎

Copy file name to clipboardExpand all lines: Lib/test/test_traceback.py

+5-4Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -4232,8 +4232,8 @@ def make_module(self, code):
4232	4232
4233	4233	return mod_name
4234	4234
4235		- def get_import_from_suggestion(self, mod_dict, name):
4236		- modname = self.make_module(mod_dict)
	4235	+ def get_import_from_suggestion(self, code, name):
	4236	+ modname = self.make_module(code)
4237	4237
4238	4238	def callable():
4239	4239	try:
@@ -4416,8 +4416,9 @@ def func():
4416	4416	def test_name_error_suggestions_with_non_string_candidates(self):
4417	4417	def func():
4418	4418	abc = 1
4419		- globals()[0] = 1
4420		- abv
	4419	+ custom_globals = globals().copy()
	4420	+ custom_globals[0] = 1
	4421	+ print(eval("abv", custom_globals, locals()))
4421	4422	actual = self.get_suggestion(func)
4422	4423	self.assertIn("abc", actual)
4423	4424

0 commit comments

Comments

0 (0)