| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 7777f42 commit 4bd3f80
3 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1563,7 +1563,8 @@ def __init__(self, file, mode='r', closefd=True, opener=None): | |||
| 1563 | 1563 | if not isinstance(fd, int): | |
| 1564 | 1564 | raise TypeError('expected integer from opener') | |
| 1565 | 1565 | if fd < 0: | |
| 1566 | - raise OSError('Negative file descriptor') | ||
| 1566 | + # bpo-27066: Raise a ValueError for bad value. | ||
| 1567 | + raise ValueError(f'opener returned {fd}') | ||
| 1567 | 1568 | owned_fd = fd | |
| 1568 | 1569 | if not noinherit_flag: | |
| 1569 | 1570 | os.set_inheritable(fd, False) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -918,15 +918,15 @@ def test_bad_opener_negative_1(self): | |||
| 918 | 918 | def badopener(fname, flags): | |
| 919 | 919 | return -1 | |
| 920 | 920 | with self.assertRaises(ValueError) as cm: | |
| 921 | - open('non-existent', 'r', opener=badopener) | ||
| 921 | + self.open('non-existent', 'r', opener=badopener) | ||
| 922 | 922 | self.assertEqual(str(cm.exception), 'opener returned -1') | |
| 923 | 923 | ||
| 924 | 924 | def test_bad_opener_other_negative(self): | |
| 925 | 925 | # Issue #27066. | |
| 926 | 926 | def badopener(fname, flags): | |
| 927 | 927 | return -2 | |
| 928 | 928 | with self.assertRaises(ValueError) as cm: | |
| 929 | - open('non-existent', 'r', opener=badopener) | ||
| 929 | + self.open('non-existent', 'r', opener=badopener) | ||
| 930 | 930 | self.assertEqual(str(cm.exception), 'opener returned -2') | |
| 931 | 931 | ||
| 932 | 932 | def test_opener_invalid_fd(self): | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,3 @@ | |||
| 1 | + Raise :exc:`ValueError` in :func:`open` if *opener* returns a negative | ||
| 2 | + file-descriptor in the Python implementation of :mod:`io` to match the | ||
| 3 | + C implementation. | ||
| Back | FazBrowse Home | New Git URL |
0 commit comments