FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add memcached container by romulojales · Pull Request #322 · testcontainers/testcontainers-python · GitHub

fix: Add memcached container - #322

Merged
alexanderankin merged 2 commits into
testcontainers:mainfrom
romulojales:add-memcached
May 11, 2024
Merged

fix: Add memcached container#322
alexanderankin merged 2 commits into
testcontainers:mainfrom
romulojales:add-memcached

Conversation

romulojales commented Mar 21, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Adding Memcached container.

You have implemented a new container and would like to contribute it? Great! Here are the necessary steps.

  • Create a new feature directory and populate it with the package structure described in the documentation. Copying one of the existing features is likely the best way to get started.
  • Implement the new feature (typically in __init__.py) and corresponding tests.
  • Add a line -e file:[feature name] to requirements.in and run make requirements. This command will find any new requirements and generate lock files to ensure reproducible builds (see the pip-tools documentation for details). Then run pip install -r requirements/[your python version].txt to install the new requirements.
  • Update the feature README.rst and add it to the table of contents (toctree directive) in the top-level README.rst.
  • Add a line [feature name] to the list of components in the GitHub Action workflow in .github/workflows/main.yml to run tests, build, and publish your package when pushed to the master branch.
  • Rebase your development branch on master (or merge master into your development branch).

romulojales marked this pull request as ready for review March 21, 2023 15:11

damjankuznar commented Jun 22, 2023
edited
Loading

Copy link
Copy Markdown

@romulojales @pffijt Can you get this merged and released?

Copy link
Copy Markdown
Contributor Author

@romulojales @pffijt Can you get this merged and released?

Hello @damjankuznar ,

I just rebased the PR with the latest main version.

Since I don't manage the project, I'm also waiting for the maintainers to review, and hopefully, approve my pr, so I could work with it without using my own fork.

alexanderankin added 👥 community feat feature but its a community module so we wont bump tc core for it and removed 👀 requires attention labels Mar 26, 2024
alexanderankin changed the title Add memcached container fix: Add memcached container May 11, 2024
alexanderankin force-pushed the add-memcached branch 2 times, most recently from 9f9e66a to 9dadeb7 Compare May 11, 2024 04:24

Copy link
Copy Markdown
Member

alexanderankin merged commit 690b9b4 into testcontainers:main May 11, 2024
alexanderankin pushed a commit that referenced this pull request May 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.4.1](testcontainers-v4.4.0...testcontainers-v4.4.1)
(2024-05-14)


### Bug Fixes

* Add memcached container
([#322](#322))
([690b9b4](690b9b4))
* Add selenium video support
[#6](#6)
([#364](#364))
([3c8006c](3c8006c))
* **core:** add empty _configure to DockerContainer
([#556](#556))
([08916c8](08916c8))
* **core:** remove version from compose tests
([#571](#571))
([38946d4](38946d4))
* **keycloak:** add realm imports
([#565](#565))
([f761b98](f761b98))
* **mysql:** Add seed support in MySQL
([#552](#552))
([396079a](396079a))
* url quote passwords
([#549](#549))
([6c5d227](6c5d227))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👥 community feat feature but its a community module so we wont bump tc core for it ✨ package: new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL