fix(build): add pre-commit as a dev dependency to simplify local dev and CI - #438
Merged
totallyzen merged 3 commits intoMar 4, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
pyproject.toml
Comment thread
pyproject.toml
pre-commit package was not present in development dependency, so pre-commit handler could not be installed locally. Also simplified CI for linting a bit. Removed black and ruff from dev dependencies After thinking about it again, just using pre-commit handling in CI is a simpler approach also for maintenance.
max-pfeiffer
force-pushed
the
feature/pre-commit-handler-dependencies
branch
from
d55cf92 to
3b0f6dc
Compare
March 2, 2024 17:38
Copy link
Copy Markdown
Member
|
i think #440 is preferable as it does not introduce any extraneous changes, @totallyzen feel free to pick one and merge. additionally we have an incorrect ruff config it looks like, which is fixed here, which i would rather 1) fix in a separate PR 2) fix after some releases because it may change the linting which just introduces more work (im not a big linting believer but we should eventually fix our config i guess) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@max-pfeiffer However!
It's not an incorrect one, the api "broke" between between 0.2 and 0.3 (config was made more explicit and old style was deprecated) and Max updated the config to match the new recommendation. I copy-pasted some old settings from another project when I set up ruff for this project so I see no reason why not jump to latest practices. It is also a cleaner definition in the pyoproject.toml |
Sorry, something went wrong.
bearrito
pushed a commit
to bearrito/testcontainers-python
that referenced
this pull request
Mar 5, 2024
…v and CI (testcontainers#438) I could not install pre-commit handler because the package was missing in [tool.poetry.group.dev.dependencies]. I also updated the configuration for the pre-commit handler as black and ruff packages were outdated. Also removed deprecation for ruff v0.3.0 config in pyproject.toml. --------- Co-authored-by: Balint Bartha <39852431+totallyzen@users.noreply.github.com>
totallyzen
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](testcontainers-v3.7.1...testcontainers-v4.0.0) (2024-03-06) ### Release Notes The breaking changes are the ones we were able to easily track. If you spot any new issues between `3.7.1` and `4.0.0`, please do report it and we'll do our best to fix everything. The release is now Some kudos from @totallyzen to folks who helped a great deal in starting things again: - kudos to @alexanderankin for his contribution on #426 - kudos to @jankatins for feedback on various PRs including - kudos to @max-pfeiffer and @bearrito for their contributions as well ### ⚠ BREAKING CHANGES * **compose:** implement compose v2 with improved typing ([#426](#426)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ### Features * **build:** use poetry and organise modules ([#408](#408)) ([6c69583](6c69583)) * **compose:** allow running specific services in compose ([f61dcda](f61dcda)) * **compose:** implement compose v2 with improved typing ([#426](#426)) ([5356caf](5356caf)) * **core:** add support for `tc.host` and de-prioritise `docker:dind` ([#388](#388)) ([2db8e6d](2db8e6d)) * **redis:** support AsyncRedisContainer ([#442](#442)) ([cc4cb37](cc4cb37)) * **release:** automate release via release-please ([#429](#429)) ([30f859e](30f859e)) ### Bug Fixes * Added URLError to exceptions to wait for in elasticsearch ([0f9ad24](0f9ad24)) * **build:** add `pre-commit` as a dev dependency to simplify local dev and CI ([#438](#438)) ([1223583](1223583)) * **build:** early exit strategy for modules ([#437](#437)) ([7358b49](7358b49)) * changed files breaks on main ([#422](#422)) ([3271357](3271357)) * flaky garbage collection resulting in testing errors ([#423](#423)) ([b535ea2](b535ea2)) * rabbitmq readiness probe ([#375](#375)) ([71cb75b](71cb75b)) * **release:** prove that the release process updates the version ([#444](#444)) ([87b5873](87b5873)) * test linting issue ([427c9b8](427c9b8)) ### Documentation * Sphinx - Add title to each doc page ([#443](#443)) ([750e12a](750e12a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not install pre-commit handler because the package was missing in [tool.poetry.group.dev.dependencies].
I also updated the configuration for the pre-commit handler as black and ruff packages were outdated. Also removed deprecation for ruff v0.3.0 config in pyproject.toml.