fix(security): Update track-modules job - #787
Conversation
Sorry, something went wrong.
|
Note to reviewer, I keep the testing so we can see it works the same. computed_modules=["scylla"] |
Sorry, something went wrong.
| dir_names: true | ||
| dir_names_exclude_current_dir: true | ||
| json: true | ||
| base: ${{ github.ref }} |
There was a problem hiding this comment.
Note: this was needed locally, we can try without on a later stage
Sorry, something went wrong.
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v42 | ||
| uses: dorny/paths-filter@v3 |
There was a problem hiding this comment.
suggestion: Can we use the pinned version of v3 (passing the commit hash)?
Sorry, something went wrong.
mdelapenya
left a comment
There was a problem hiding this comment.
BTW the GH action was restored removing the offending commit. In the case we want to keep it, I'd encourage using a pinned version of the action. And if possible, also pin any other GH action
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage ? 84.73%
=======================================
Files ? 12
Lines ? 668
Branches ? 105
=======================================
Hits ? 566
Misses ? 79
Partials ? 23 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
alexanderankin
left a comment
There was a problem hiding this comment.
test
Sorry, something went wrong.
🤖 I have created a release *beep* *boop* --- ## [4.10.0](testcontainers-v4.9.2...testcontainers-v4.10.0) (2025-04-02) ### Features * Add SocatContainer ([#795](#795)) ([2f9139c](2f9139c)) ### Bug Fixes * **ollama:** make device request a list ([#799](#799)) ([9497a45](9497a45)) * **security:** Update track-modules job ([#787](#787)) ([f979525](f979525)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This will address the Security issue reported on #786
As recommended, tj-actions/changed-files was replace replaced with path-filter