FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Enable mypy in the CI by Tranquility2 · Pull Request #842 · testcontainers/testcontainers-python · GitHub

fix: Enable mypy in the CI - #842

Merged
Tranquility2 merged 7 commits into
mainfrom
fix_mypy_config
Jul 3, 2025
Merged

fix: Enable mypy in the CI#842
Tranquility2 merged 7 commits into
mainfrom
fix_mypy_config

Conversation

Tranquility2 commented Jul 2, 2025
edited
Loading

Copy link
Copy Markdown
Contributor
  1. leftovers from a previous mypy refactor
core/testcontainers/core/config.py:42: error: Redundant cast to "str"  [redundant-cast]
            socket_path = cast("str", socket_path)

Post fix:

#poetry run mypy --config-file pyproject.toml core
Success: no issues found in 36 source files
  1. add mypy check to the CI under lint, also create a simple report if something is wrong.

Tranquility2 changed the title fix: address mypy issue in config fix: Enable mypy in the CI Jul 2, 2025
Tranquility2 force-pushed the fix_mypy_config branch 2 times, most recently from 201cd8a to 309efdf Compare July 3, 2025 09:36
fix report

more report fixes

fix pipeline

fix2
Tranquility2 force-pushed the fix_mypy_config branch 2 times, most recently from e201113 to af6b0b9 Compare July 3, 2025 11:14

Copy link
Copy Markdown
Contributor Author

Happy flow:

On error:

alexanderankin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

approving with the caveat that i have not run the mypy_report.py on my laptop once yet

Tranquility2 merged commit ef65bd1 into main Jul 3, 2025
Tranquility2 deleted the fix_mypy_config branch July 3, 2025 12:26
alexanderankin pushed a commit that referenced this pull request Jul 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.12.0](testcontainers-v4.11.0...testcontainers-v4.12.0)
(2025-07-21)


### Features

* **main:** New Testcontainers Python Docs Site
([#822](#822))
([a6bdf0e](a6bdf0e))
* make config monkeypatchable, fix config related startup issues
([#833](#833))
([ff6a32d](ff6a32d))
* **modules:** add OpenFGA module
([#762](#762))
([0b7b482](0b7b482))
* set multiple variables via keyword args
([#804](#804))
([1532df5](1532df5))


### Bug Fixes

* **core:** mypy
([#810](#810))
([b816762](b816762))
* Enable mypy in the CI
([#842](#842))
([ef65bd1](ef65bd1))
* just use the getLogger API and do not override logger settings
([#836](#836))
([f467c84](f467c84))


### Documentation

* missing compose html from old docs
([#776](#776))
([d749fc6](d749fc6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL