fix(core): make sure context manager exits - #876
Merged
alexanderankin merged 3 commits intoSep 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looked through it, and my initial thought was that this is somewhat similar to the problem that ExitStack tries to solve, but at the same time ExitStack is very niche, so that is it much more maintainable to do it your way |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
exit stack takes so much more code. its kind of horrific either way. im open to improvements now or later. |
Sorry, something went wrong.
santi
self-requested a review
September 22, 2025 14:17
santi
approved these changes
Sep 22, 2025
alexanderankin
pushed a commit
that referenced
this pull request
Sep 24, 2025
🤖 I have created a release *beep* *boop* --- ## [4.13.1](testcontainers-v4.13.0...testcontainers-v4.13.1) (2025-09-24) ### Bug Fixes * **core:** Added 'compose' in compose_command_property ([#879](#879)) ([769b7b6](769b7b6)) * **core:** make sure context manager exits ([#876](#876)) ([10089f6](10089f6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe don't write your software in python