fix: issue #889 by changing the annotated return type of waiting_for to Self. - #890
Merged
alexanderankin merged 1 commit intoOct 2, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… `waiting_for` to `Self`.
alexanderankin
approved these changes
Oct 2, 2025
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage ? 78.89%
=======================================
Files ? 14
Lines ? 1161
Branches ? 180
=======================================
Hits ? 916
Misses ? 206
Partials ? 39 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
alexanderankin
pushed a commit
that referenced
this pull request
Oct 7, 2025
🤖 I have created a release *beep* *boop* --- ## [4.13.2](testcontainers-v4.13.1...testcontainers-v4.13.2) (2025-10-07) ### Bug Fixes * **core:** Fix issues with doctests ([#893](#893)) ([2e4d80a](2e4d80a)) * **core:** waiting improvements + remove decorators in core ([#894](#894)) ([f93f379](f93f379)) * issue [#889](#889) by changing the annotated return type of `waiting_for` to `Self`. ([#890](#890)) ([fe941b1](fe941b1)) * **mongo:** mongo start waiting forever for old mongo versions ([#783](#783)) ([1388612](1388612)) * **redpanda:** copy the startup script to a path that can be written … ([#867](#867)) ([e6b976d](e6b976d)) * **trino:** Remove deprecated class and decorator from Trino container ([#895](#895)) ([bb646e9](bb646e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #889 by changing the annotated return type of waiting_for to Self.