fix(core): Use WaitStrategy internally for wait_for function - #942
Merged
alexanderankin merged 1 commit intoJan 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #942 +/- ##
==========================================
- Coverage 78.30% 77.96% -0.34%
==========================================
Files 14 14
Lines 1212 1216 +4
Branches 141 142 +1
==========================================
- Hits 949 948 -1
- Misses 222 227 +5
Partials 41 41 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Refactor the deprecated wait_for function to use the new WaitStrategy system internally instead of the @wait_container_is_ready decorator. The decorator emitted a deprecation warning at decoration time (import time), causing warnings even when users never called wait_for. Replace with an internal CallableWaitStrategy that uses WaitStrategy._poll() for retry logic. This follows the intended migration path to the new system. Fixes testcontainers#874
alexanderankin
force-pushed
the
fix/core-wait-for-deprecated-decorator
branch
from
05b816e to
3949ffa
Compare
January 19, 2026 17:34
alexanderankin
approved these changes
Jan 19, 2026
alexanderankin
pushed a commit
that referenced
this pull request
Jan 31, 2026
🤖 I have created a release *beep* *boop* --- ## [4.14.1](testcontainers-v4.14.0...testcontainers-v4.14.1) (2026-01-31) ### Bug Fixes * Allow passing in a custom wait strategy string in MySQL, Cassandra, Kafka and Trino ([#953](#953)) ([be4d09e](be4d09e)) * **compose:** expose useful compose options ([#951](#951)) ([183e1aa](183e1aa)) * **core:** bring back dind tests ([7337266](7337266)) * **core:** Use WaitStrategy internally for wait_for function ([#942](#942)) ([e323317](e323317)) * **nats:** add support for jetstream ([#938](#938)) ([49c9af8](49c9af8)) * Support Elasticsearch 9.x ([#881](#881)) ([f690e88](f690e88)), closes [#860](#860) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): Use WaitStrategy internally for wait_for function
Summary
Refactor the deprecated wait_for function to use the new WaitStrategy system internally instead of the @wait_container_is_ready decorator.
This fixes the import-time deprecation warning from #874.
See alexanderankin's comment stating core should no longer warn, and jonaslb's reply identifying that wait_for is still decorated with @wait_container_is_ready at module level, so it generates a warning.
Problem
The wait_for function was decorated with @wait_container_is_ready(), which emits a deprecation warning at decoration time (import time), not when the function is called. This caused warnings even when users never used wait_for.
Reproducer
=============================== warnings summary =============================== waiting_utils.py:215: DeprecationWarning: The @wait_container_is_ready decorator is deprecated and will be removed in a future version... @wait_container_is_ready() 1 passed, 1 warningNote: wait_for is never called - the warning is emitted just by importing the module.