Fixed read_user_by_id docstring - #4
Merged
tiangolo merged 2 commits intoMar 29, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Incorrectly documented as "Get a specific user by username (email)". Changed to "Get a specific user by id".
Fixed read_user_by_id docstring
Copy link
Copy Markdown
Member
|
Thanks! Good catch. |
Sorry, something went wrong.
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
Fix incorrectly documented as "Get a specific user by username (email)". Changed to "Get a specific user by id".
alejsdev
pushed a commit
that referenced
this pull request
Dec 19, 2024
cassimon
pushed a commit
to cassimon/plains
that referenced
this pull request
Jun 24, 2026
Run fastapi#4 confirmed the backend now starts healthy (circular-import fix worked); the remaining failures were test-harness wiring, not app bugs: - compose.test.yml: mount ./backend/tests into the backend container. The production image only copies ./backend/app, so the previous run failed with "file or directory not found: tests/integration/". - conftest.py: read API_BASE_URL (set by the CI exec step and used by the Playwright suite) before the older INTEGRATION_API_BASE name. The old default pointed at host port 8001, unreachable from inside the container where the backend listens on 8000. - Align superuser credentials: pin FIRST_SUPERUSER_PASSWORD in .env to the value the tests log in with (the .env.example placeholder is CHANGE_THIS, but the Playwright step used 'changethis'); drive both test steps from shared job-level env. Match the conftest defaults too. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JuJaTjEPCdk39mhYFaGkPb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed doctring from "Get a specific user by username (email)" to "Get a specific user by id". Not the biggest PR in the world ;)