Repository navigation
💚 Fix CI installs and tests - #2
Merged
tiangolo merged 12 commits intoAug 24, 2021
Merged
tiangolo merged 12 commits into
tiangolo merged 12 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage ? 97.24%
=======================================
Files ? 175
Lines ? 5842
Branches ? 0
=======================================
Hits ? 5681
Misses ? 161
Partials ? 0 Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
🚀 Deployed on https://612536c385f2b5135da5deb7--sqlmodel.netlify.app |
Sorry, something went wrong.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💚 Fix CI installs and tests.
Poetry 1.2.0ax currently has an issue that was solved here: python-poetry/poetry-core#188, but is not released in the alpha branches.
This project uses Poetry 1.2.0ax to be able to use the Poetry Version Plugin https://github.com/tiangolo/poetry-version-plugin
Until there's a new release with that fix, this change installs poetry-core from Git, pinned to the version that fixes the problem.
This PR also fixes several dangling issues detected by the first CI runs, missing dev dependencies, type annotations, etc.