FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

馃摑 Clarify description of in-memory SQLite database in `docs/tutorial/create-db-and-table.md` by SimonCW 路 Pull Request #601 路 fastapi/sqlmodel 路 GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

馃摑 Clarify description of in-memory SQLite database in docs/tutorial/create-db-and-table.md - #601

Merged
tiangolo merged 3 commits into
fastapi:mainfrom
SimonCW:patch-1
Oct 23, 2023
ConversationCommits聽(3)ChecksFiles changed
Merged

馃摑 Clarify description of in-memory SQLite database in docs/tutorial/create-db-and-table.md#601
tiangolo merged 3 commits into
fastapi:mainfrom
SimonCW:patch-1

Conversation

SimonCW commented May 31, 2023

Copy link
Copy Markdown
Contributor

Tried to make the docs more clear by avoiding confusion about the in-memory url for sqlite.

Why:
I was quite confused because I didn't notice the difference between the sqlite urls with a filename and without a filename, using only two "//". Also, I first thought the in-memory database would be provided by SQLAlchemy, but only the url format is determined by SQLAlchemy.

SimonCW commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Tried to fix the CI here #602, but ultimately failed because poetry-version-plugin isn't working anymore.

antont commented Jun 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Tried to fix the CI here #602, but ultimately failed because poetry-version-plugin isn't working anymore.

This seems to have poetry updates.

#603

SimonCW commented Jun 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yeah, I didn't see this. I since then got #602 to work and unblock CI .

I assume tiangolo is currently quite busy with the pedantic V2 migration for FastAPI

tiangolo added the docs Improvements or additions to documentation label Oct 22, 2023

tiangolo commented Oct 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I confused two PRs, sorry! Reopening this.

tiangolo closed this Oct 23, 2023
tiangolo reopened this Oct 23, 2023
tiangolo changed the title Clarify description of in-memory sqlite 馃摑 Clarify description of in-memory SQLite database Oct 23, 2023
tiangolo changed the title 馃摑 Clarify description of in-memory SQLite database 馃摑 Clarify description of in-memory SQLite database in docs/tutorial/create-db-and-table.md Oct 23, 2023

tiangolo commented Oct 23, 2023

Copy link
Copy Markdown
Member

Great, thank you! 馃殌 馃嵃

tiangolo enabled auto-merge (squash) October 23, 2023 20:44
tiangolo merged commit 80fd7e0 into fastapi:main Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL