FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

✏ Fix broken link to newsletter sign-up in `docs/help.md` by mborus · Pull Request #84 · fastapi/sqlmodel · GitHub

Repository navigation

✏ Fix broken link to newsletter sign-up in docs/help.md - #84

Merged
tiangolo merged 3 commits into
fastapi:mainfrom
mborus:patch-1
Aug 27, 2022
Merged

tiangolo merged 3 commits into
fastapi:mainfrom
mborus:patch-1

Conversation

mborus commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

Trying to subscribe to the newletter by clicking on https://sqlmodel.tiangolo.com/newsletter/ gives a 404 error,

Maybe change URL to https://fastapi.tiangolo.com/newsletter/ to make it work?

Trying to subscribe to the newletter by clicking on https://sqlmodel.tiangolo.com/newsletter/ gives a 404 error, 

Maybe change URL to https://fastapi.tiangolo.com/newsletter/ to make it work?
Comment thread docs/help.md Outdated
tiangolo changed the title Fix broken link to newsletter sign-up ✏ Fix broken link to newsletter sign-up Aug 27, 2022

codecov Bot commented Aug 27, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #84 (937d3b2) into main (9664c88) will not change coverage.
The diff coverage is n/a.

❗ Current head 937d3b2 differs from pull request most recent head 9ef4154. Consider uploading reports for the commit 9ef4154 to get more accurate results

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         182      182           
  Lines        6054     6054           
=======================================
  Hits         5908     5908           
  Misses        146      146           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tiangolo changed the title ✏ Fix broken link to newsletter sign-up ✏ Fix broken link to newsletter sign-up in docs/help.md Aug 27, 2022

Copy link
Copy Markdown
Member

Good catch, thank you! 🤓

tiangolo enabled auto-merge (squash) August 27, 2022 20:30
tiangolo merged commit 31beaf1 into fastapi:main Aug 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL