Repository navigation
Commit d91e998
committed
fix: add missing break in SX1280 switch case
The RADIO_SX1280 case was missing a break statement, causing it to fall
through to the default case. This overwrote the SX1280 RadioHal with an
SX1268 RadioHal, leaked the SX1280 object, and used the wrong radio module.
All boards configured for SX1280 (e.g. LilyGo T3S3 2.4GHz) were silently
running with an SX1268 driver, which would fail to initialize or behave
incorrectly on the 2.4GHz radio hardware.1 parent 6f9bdcb commit d91e998
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -88,6 +88,7 @@ void Radio::init() | |||
| 88 | 88 | case RADIO_SX1280: | |
| 89 | 89 | radioHal = new RadioHal<SX1280>(new Module(board.L_NSS, board.L_DI01, board.L_RST, board.L_BUSSY, spi, SPISettings(2000000, MSBFIRST, SPI_MODE0))); | |
| 90 | 90 | moduleNameString="SX1280"; | |
| 91 | + break; | ||
| 91 | 92 | default: | |
| 92 | 93 | radioHal = new RadioHal<SX1268>(new Module(board.L_NSS, board.L_DI01, board.L_RST, board.L_BUSSY, spi, SPISettings(2000000, MSBFIRST, SPI_MODE0))); | |
| 93 | 94 | moduleNameString="default SX1268"; | |
0 commit comments