FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(master): Added `hide-pane` and `show-pane`. by daneofmanythings · Pull Request #5402 · tmux/tmux · GitHub

/ tmux Public

feat(master): Added hide-pane and show-pane. - #5402

Draft
daneofmanythings wants to merge 1 commit into
tmux:masterfrom
daneofmanythings:hide-show-pane
Draft

feat(master): Added hide-pane and show-pane.#5402
daneofmanythings wants to merge 1 commit into
tmux:masterfrom
daneofmanythings:hide-show-pane

Conversation

daneofmanythings commented Jul 16, 2026
edited
Loading

Copy link
Copy Markdown
Member

There are two small annoyances with the current implementation.

  1. When all panes in a window are minimised, show-pane needs the window to be qualified to identify a pane to target. #5223. I want to fix this before merging if possible.
  2. The last visible pane cannot be hidden. This would result in the active pane being NULL. This can be fixed, but it would require a scope of change beyond this PR. A non-NULL active pane invariant is enforced on cmd-find.c:1004. I believe allowing a NULL active pane would require NULL checks in all the consumers of cmd_find_target.

Hide pane cannot be used on the last visible pane.
github-project-automation Bot moved this to Not Started in Open Issues & PRs Jul 16, 2026
daneofmanythings moved this from Not Started to For Review in Open Issues & PRs Jul 16, 2026
daneofmanythings marked this pull request as draft July 16, 2026 06:14

nicm commented Jul 16, 2026

Copy link
Copy Markdown
Member

For this:

		cmdq_error(item, "can't show a pane while window is zoomed");

Why not just unzoom? Isn't that what we normally do?

Is having this (hidden panes) going to make layout changes harder? I don't think we have a pressing need for hidden panes if they are going to cause any problems and could be done later.

Copy link
Copy Markdown
Member Author

Right, yes. I don't recall why that is in there. I'll adjust that.

Adding hidden panes will make layouts a little more complicated and will necessarily make adding features take more consideration. I'm not sure as to the magnitude of the effect, but there is something I should probably audit in this PR, and that is window_count_panes. It was given a parameter to interact with floating panes, and will need one for hidden as well. It feels like the function should be broken up into how it is used, instead of making a flag soup. It looks like it cares about counting visible, tiled, and all panes. I couldn't see any other immediate effects.

This feature can certainly wait as its impact on complexity is non-zero!

nicm mentioned this pull request Jul 17, 2026
18 tasks
daneofmanythings moved this from For Review to In Progress in Open Issues & PRs Jul 21, 2026
nicm moved this from In Progress to For Review in Open Issues & PRs Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: For Review

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL