FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Comparing livekit:main...trialize:main · livekit/server-sdk-ruby · GitHub

/ server-sdk-ruby Public
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: livekit/server-sdk-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
Could not load branches
Nothing to show
{{ refName }}
...
head repository: trialize/server-sdk-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Could not load branches
Nothing to show
{{ refName }}
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 4 contributors

Commits on Jun 25, 2026

  1. Fix delete/get/list_dispatch: keyword auth_header + ClientResp.data u… 

    …nwrap

delete_dispatch, get_dispatch and list_dispatch pass the grant positionally to AuthMixin#auth_header, which only accepts the `video_grant:` keyword, so every call raises ArgumentError ("wrong number of arguments (given 1, expected 0)") before reaching the server. create_dispatch is the only method that passes it correctly.

get_dispatch and list_dispatch additionally read .agent_dispatches directly off the Twirp::ClientResp returned by rpc, rather than its .data payload — a latent NoMethodError the auth_header bug masked.

Pass video_grant: and unwrap res.data in all three methods.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
    trialize and claude committed Jun 25, 2026
    Configuration menu
    Copy the full SHA
    b01d150 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from trialize/fix/agent-dispatch-auth-header-an… 

    …d-resp-unwrap

Fix delete/get/list_dispatch: keyword auth_header + ClientResp .data unwrap
    trialize authored Jun 25, 2026
    Configuration menu
    Copy the full SHA
    b1bfdb2 View commit details
    Browse the repository at this point in the history

  3. list/get_dispatch: handle nil ClientResp.data for empty rooms 

    ListDispatch returns a ClientResp whose .data is nil for a room with no dispatches, so res.data.agent_dispatches raised NoMethodError. list_dispatch now returns [] and get_dispatch returns nil in that case. Follow-up to #1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
    trialize and claude committed Jun 25, 2026
    Configuration menu
    Copy the full SHA
    bad1b94 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from trialize/fix/list-dispatch-nil-data 

    list/get_dispatch: handle nil ClientResp.data for empty rooms
    trialize authored Jun 25, 2026
    Configuration menu
    Copy the full SHA
    843939a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2026

  1. create_sip_participant: expose wait_until_answered 

    The protocol already carries CreateSIPParticipantRequest.wait_until_answered
(field 19); expose it as a kwarg so callers can make the RPC block until the
callee actually answers (or fails / ringing_timeout elapses) — the
answer-authoritative signal, with no webhook or attribute-polling dependency.
Default false preserves existing behavior.
    Leo Stoianov committed Jul 24, 2026
    Configuration menu
    Copy the full SHA
    5a533cb View commit details
    Browse the repository at this point in the history
Loading
Back | FazBrowse Home | New Git URL