Use uuid instead of tempfile.mkdtmp, which created an actual directory. · uri-canva/GitPython@5ac93b1 · GitHub

1. uri-canva
2. GitPython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 5ac93b1

Browse filesBrowse the repository at this point in the historyBrowse files

Byron

committed

Use uuid instead of tempfile.mkdtmp, which created an actual directory.

That, over time, could have caused slow downs due to file-system hassle. Fixes gitpython-developers#258

1 parent f51fe3e commit 5ac93b1
Copy full SHA for 5ac93b1

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/objects/submodule
  • base.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -37,7 +37,7 @@
37	37
38	38	import os
39	39	import logging
40		- import tempfile
	40	+ import uuid
41	41
42	42	__all__ = ["Submodule", "UpdateProgress"]
43	43
@@ -992,7 +992,7 @@ def rename(self, new_name):
992	992	source_dir = mod.git_dir
993	993	# Let's be sure the submodule name is not so obviously tied to a directory
994	994	if destination_module_abspath.startswith(mod.git_dir):
995		- tmp_dir = self._module_abspath(self.repo, self.path, os.path.basename(tempfile.mkdtemp()))
	995	+ tmp_dir = self._module_abspath(self.repo, self.path, str(uuid.uuid4()))
996	996	os.renames(source_dir, tmp_dir)
997	997	source_dir = tmp_dir
998	998	# end handle self-containment

0 commit comments

Comments

0 (0)