Fixes QR code URL containing uninerpolated env variable · willCode2Surf/JavaScriptButtons@110cedc · GitHub

willCode2Surf / JavaScriptButtons Public

forked from jbillimoria/JavaScriptButtons

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 110cedc

Browse filesBrowse the repository at this point in the historyBrowse files

Cristiano Betta

committed

Fixes QR code URL containing uninerpolated env variable

The QR code encoded URL still contained a {env} token. Has been replaced with the right env now.

1 parent f211973 commit 110cedc
Copy full SHA for 110cedc

5 files changed

+18-12Lines changed: 18 additions & 12 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• dist
  • paypal-button-minicart.js
  • paypal-button-minicart.min.js
  • paypal-button.js
  • paypal-button.min.js
• src
  • paypal-button.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎dist/paypal-button-minicart.js‎

Copy file name to clipboardExpand all lines: dist/paypal-button-minicart.js

+5-3Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,7 @@
1	1	/*!
2	2	* PayPalJSButtons
3	3	* JavaScript integration for PayPal's payment buttons
4		- * @version 1.0.1 - 2013-04-13
	4	+ * @version 1.0.1 - 2013-04-28
5	5	* @author Jeff Harrell <https://github.com/jeffharrell/>
6	6	*/
7	7	/*!
@@ -2010,8 +2010,10 @@ PAYPAL.apps = PAYPAL.apps || {};
2010	2010	* @return {HTMLElement}
2011	2011	*/
2012	2012	function buildQR(data, size) {
	2013	+ var baseUrl = paypalURL.replace('{env}', data.items.env.value);
	2014	+
2013	2015	var img = document.createElement('img'),
2014		- url = paypalURL + '?',
	2016	+ url = baseUrl + '?',
2015	2017	pattern = 13,
2016	2018	items = data.items,
2017	2019	item, key;
@@ -2026,7 +2028,7 @@ PAYPAL.apps = PAYPAL.apps || {};
2026	2028
2027	2029	url = encodeURIComponent(url);
2028	2030	img.src = qrCodeURL.replace('{env}', data.items.env.value).replace('{url}', url).replace('{pattern}', pattern).replace('{size}', size);
2029		-
	2031	+ console.log(img.src);
2030	2032	return img;
2031	2033	}
2032	2034

Collapse file

‎dist/paypal-button-minicart.min.js‎

Copy file name to clipboardExpand all lines: dist/paypal-button-minicart.min.js

+2-2Lines changed: 2 additions & 2 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎dist/paypal-button.js‎

Copy file name to clipboardExpand all lines: dist/paypal-button.js

+5-3Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,7 @@
1	1	/*!
2	2	* PayPalJSButtons
3	3	* JavaScript integration for PayPal's payment buttons
4		- * @version 1.0.1 - 2013-04-13
	4	+ * @version 1.0.1 - 2013-04-28
5	5	* @author Jeff Harrell <https://github.com/jeffharrell/>
6	6	*/
7	7	if (typeof PAYPAL === 'undefined' || !PAYPAL) {
@@ -277,8 +277,10 @@ PAYPAL.apps = PAYPAL.apps || {};
277	277	* @return {HTMLElement}
278	278	*/
279	279	function buildQR(data, size) {
	280	+ var baseUrl = paypalURL.replace('{env}', data.items.env.value);
	281	+
280	282	var img = document.createElement('img'),
281		- url = paypalURL + '?',
	283	+ url = baseUrl + '?',
282	284	pattern = 13,
283	285	items = data.items,
284	286	item, key;
@@ -293,7 +295,7 @@ PAYPAL.apps = PAYPAL.apps || {};
293	295
294	296	url = encodeURIComponent(url);
295	297	img.src = qrCodeURL.replace('{env}', data.items.env.value).replace('{url}', url).replace('{pattern}', pattern).replace('{size}', size);
296		-
	298	+ console.log(img.src);
297	299	return img;
298	300	}
299	301

0 commit comments

Comments

0 (0)