refactor(api): address PR review comments · wonderwebworkspace/httpsms@01f3650 · GitHub

wonderwebworkspace / httpsms Public

forked from NdoleStudio/httpsms

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 01f3650

Browse filesBrowse the repository at this point in the historyBrowse files

AchoArnold

and

Copilot

committed

refactor(api): address PR review comments

- Remove leftover 'fiber:context-methods migrated' annotation in otel_tracer.go - Guard body-based API key extraction with c.HasBody() to avoid attempting Bind().Body() on bodyless requests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

1 parent 6d7876d commit 01f3650
Copy full SHA for 01f3650

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• api/pkg
  • middlewares
    • api_key_auth_middleware.go
  • telemetry
    • otel_tracer.go

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎api/pkg/middlewares/api_key_auth_middleware.go‎

Copy file name to clipboardExpand all lines: api/pkg/middlewares/api_key_auth_middleware.go

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -47,8 +47,10 @@ func getAPIKeyFromRequest(c fiber.Ctx) string {
47	47	APIKey string `json:"x-api-key" form:"x-api-key" query:"x-api-key"`
48	48	}{}
49	49
50		- if err := c.Bind().Body(&payload); err == nil && payload.APIKey != "" {
51		- return payload.APIKey
	50	+ if c.HasBody() {
	51	+ if err := c.Bind().Body(&payload); err == nil && payload.APIKey != "" {
	52	+ return payload.APIKey
	53	+ }
52	54	}
53	55
54	56	if err := c.Bind().Query(&payload); err != nil {

Collapse file

‎api/pkg/telemetry/otel_tracer.go‎

Copy file name to clipboardExpand all lines: api/pkg/telemetry/otel_tracer.go

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -84,5 +84,3 @@ func functionName() string {
84	84
85	85	return strings.ReplaceAll(frame.Function, "github.com/NdoleStudio/http-sms-manager/", "")
86	86	}
87		-
88		- // fiber:context-methods migrated

0 commit comments

Comments

0 (0)