Skip the QE eval-run tests without the qe extra · ymoslem/CRE-Router@51f6717 · GitHub

ymoslem / CRE-Router Public

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 2

• Code
• Issues 1
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 51f6717

Browse filesBrowse the repository at this point in the historyBrowse files

ymoslem

committed

Skip the QE eval-run tests without the qe extra

`datasets` is an optional dependency, so importing it at module scope broke collection on a base install and failed both the tests and release workflows. Guard it with importorskip, and install `datasets` in the tests workflow so the module runs instead of skipping.

1 parent f517a18 commit 51f6717
Copy full SHA for 51f6717

2 files changed

+10-3Lines changed: 10 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • tests.yml
• tests
  • test_qe_eval_run.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/tests.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/tests.yml

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -14,7 +14,9 @@ jobs:
14	14	with:
15	15	python-version: ${{ matrix.python-version }}
16	16	cache: pip
17		- - run: pip install -e . pytest check-manifest
	17	+ # `datasets` is the one `qe` extra the tests import; without it the QE
	18	+ # eval-run tests skip instead of running.
	19	+ - run: pip install -e . pytest check-manifest datasets
18	20	- run: pytest -q
19	21	# The sdist must contain exactly the tracked tree, no more and no less.
20	22	- run: check-manifest

Collapse file

‎tests/test_qe_eval_run.py‎

Copy file name to clipboardExpand all lines: tests/test_qe_eval_run.py

+7-2Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -5,12 +5,17 @@
5	5	into the data; TeleQnA-router ships all five runs with `run` as a column, and
6	6	before it was restructured the default split selection silently picked a single
7	7	(cluster, run) slice instead, which is what this filter replaces.
	8	+
	9	+ Needs the `qe` extra.
8	10	"""
9	11
10	12	import pytest
11		- from datasets import Dataset
12	13
13		- from cre_router.qe.train import select_eval_run
	14	+ pytest.importorskip("datasets")
	15	+
	16	+ from datasets import Dataset # noqa: E402
	17	+
	18	+ from cre_router.qe.train import select_eval_run # noqa: E402
14	19
15	20
16	21	def five_runs(questions=4, runs=5):

0 commit comments

Comments

0 (0)