Repository navigation
Fix ancestor handling - #1646
Merged
waylan merged 2 commits intoSep 30, 2026
Merged
waylan merged 2 commits into
waylan merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Ancestors used to continually add duplicate parents that were already present. Call `__build_ancestors` once at the beginning and then manage ancestors as appropriate.
Copy link
Copy Markdown
Collaborator
Author
|
To clarify the motivation for this change. The ancestor handling used to duplicate parents that were already added. This could cause real performance issues for certain patterns: Before, parent tags would get duplicated. Notice div and p constantly being duplicated. >>> import markdown
>>> text = '**_test_* ******test*******'
>>> markdown.markdown(text, extensions=['pymdownx.betterem'])
['div']
['div', 'p', 'div', 'p', 'em']
['div', 'p', 'div', 'p', 'em', 'div', 'p', 'em', 'em']
['div', 'p', 'div', 'p', 'em', 'div', 'p', 'em', 'strong']
['div', 'p', 'div', 'p', 'em', 'div', 'p', 'em', 'strong', 'div', 'p', 'em', 'strong', 'strong']
'<p><em><em><em>test</em></em> <strong><strong><strong>test</strong></strong></strong></em></p>'Now, they get handled more reasonably: ➜ markdown_fork git:(fix-ancestors) ✗ python3
Python 3.14.7 (v3.14.7:823f0323ee6, Aug 5 2026, 07:07:01) [Clang 21.0.0 (clang-2100.1.1.101)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import markdown
>>> text = '**_test_* ******test*******'
>>> markdown.markdown(text, extensions=['pymdownx.betterem'])
['div']
['div', 'p', 'em']
['div', 'p', 'em', 'em']
['div', 'p', 'em', 'strong']
['div', 'p', 'em', 'strong', 'strong']
'<p><em><em><em>test</em></em> <strong><strong><strong>test</strong></strong></strong></em></p>'This reduces performance degradation for certain patterns. |
Sorry, something went wrong.
facelessuser
marked this pull request as ready for review
September 30, 2026 14:08
waylan
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ancestors used to continually add duplicate parents that were already present.
Call __build_ancestors once at the beginning and then manage ancestors as appropriate.
Description
AI Assistance Disclosure
Checklist