Add Maven dependency-resolution repositories - #1240
Merged
brunoborges merged 2 commits intoAug 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8897ad63-2d05-4a6d-8ccd-c1155348b59e
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for configuring Maven dependency-resolution repositories in the generated settings.xml, so workflows can consume dependencies from private/internal repositories without hand-writing or patching Maven settings, while preserving existing behavior when the feature is unused.
Changes:
- Introduces new inputs (mvn-repositories, mvn-repositories-include-central, mvn-repositories-prioritize-central) and parses/validates them into structured settings.
- Extends settings.xml generation to emit an active profile containing <repositories> (including Central ordering/disable semantics) and composes cleanly with the existing GPG profile.
- Updates documentation, tests, and rebuilt dist/ bundles.
| File | Description |
|---|---|
| src/constants.ts | Adds input names and Maven Central/profile constants used by the new feature. |
| src/auth.ts | Parses repository inputs and generates <profiles>/<repositories> plus <activeProfiles> in settings.xml. |
| README.md | Documents new inputs and adds a pointer to the advanced usage section. |
| docs/advanced-usage.md | Adds a full usage guide and example output for custom dependency repositories. |
| action.yml | Declares new action inputs and defaults for Central inclusion/ordering. |
| tests/auth.test.ts | Adds unit tests for parsing and XML generation (ordering, Central disable/override, escaping, composition with GPG). |
| dist/setup/index.js | Rebuilt bundle exporting new constants used by the action runtime. |
| dist/setup/81.index.js | Rebuilt bundle for auth logic (parsing + settings generation updates). |
| dist/cleanup/index.js | Rebuilt bundle reflecting newly exported constants. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/9 changed files
- Comments generated: 1
- Review effort level: Lite
Sorry, something went wrong.
Comment thread
README.md
Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Maven builds that consume artifacts from private or internal repositories currently need to create or patch settings.xml themselves. This adds first-class dependency-resolution repository configuration while preserving the existing generated settings when the feature is unused.
The new mvn-repositories multiline input accepts repository-id:repository-url:snapshots-enabled entries and composes repository profiles with existing server credentials and GPG profiles. Additional inputs control whether Maven Central is included and whether it is searched first. Disabling Central emits a disabled override for Maven's Super POM repository, while an explicit central entry can replace it. The generated bundles and usage documentation are included.
Related issue:
Fixes: #1054
Check list: